Skip to content
This repository was archived by the owner on Jul 15, 2025. It is now read-only.

Conversation

@karllessard
Copy link
Contributor

As discussed and voted by SIG JVM, the minimal supported JDK version for distributed artifacts has moved from Java8 to Java11. Java17 build is also supported by the activation of the jdk17 Maven profile.

@karllessard karllessard marked this pull request as ready for review February 12, 2022 15:25
@Craigacp
Copy link
Contributor

Should we add a module-info.java at the same time? I think it would be pretty short, just adding a dependency on jdk.unsupported for Unsafe.

@karllessard
Copy link
Contributor Author

karllessard commented Feb 16, 2022

@Craigacp , so I've checked at the different options on how to support unit testing with Java modules in a classic Maven project setup and none are very appealing, so I suggest that we continue to simply disable the module path in the surefire plugin config like I currently do, and let unit tests use the regular classpath instead.

Copy link
Contributor

@Craigacp Craigacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Craigacp
Copy link
Contributor

@Craigacp , so I've checked at the different options on how to support unit testing with Java modules in a classic Maven project setup and none are very appealing, so I suggest that we continue to simply disable the module path in the surefire plugin config like I currently do, and let unit tests use the regular classpath instead.

Sure. Module testing is a pain and if it's going to cause a lot of problems we can leave it till later.

@karllessard karllessard merged commit 283be2b into tensorflow:main Feb 16, 2022
@karllessard karllessard deleted the jdk11 branch February 16, 2022 03:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants