Some Fixes #7
Open
Some Fixes #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging level is filtered by the Loggers, there is no need to restrict it at the handler level. It is also useful to let the handler level on ALL to allow specifying finer levels for specific classes using a logging file configuration. Some optimizations are made to avoid computing String.format and the stack trace.
LineMap.getPosition(line,col) expands tabs to spaces causing position mismatch when editing source files with tabs, use getStartPosition instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes and cleanups: logging, lineMap position mismatch, incremental completion when prefix length is 0.