dx(compiler-core): warn for directive shorthands without an argument #7360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/compiler-dom/src/errors.ts # packages/compiler-ssr/src/errors.ts
Size ReportBundles
Usages
|
# Conflicts: # packages/compiler-core/src/parse.ts
CodSpeed Performance ReportMerging #7360 will not alter performanceComparing Summary
|
# Conflicts: # packages/compiler-core/__tests__/__snapshots__/parse.spec.ts.snap # packages/compiler-core/__tests__/parse.spec.ts # packages/compiler-core/src/errors.ts # packages/compiler-core/src/parse.ts # packages/compiler-dom/src/errors.ts # packages/compiler-ssr/src/errors.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is closely related to my other PR, #7359. There is significant overlap between them and merging one will cause conflicts for the other.
Vue 3 unintentionally introduced the ability to use the shorthands
:,@,#and.without an argument. For example,:="obj"is equivalent tov-bind="obj". This isn't documented and I believe support for this was intentionally avoided in Vue 2, e.g. when the#shorthand was introduced. It is just a little bit too magical having the attribute name as pure punctuation.I've seen this used on Vue Land, so it definitely does happen in real applications.
The compiler currently doesn't use warnings, only errors. However, I felt an error would be too severe for the initial introduction of this check as it would prevent some applications from building. As it isn't documented it wouldn't technically be a breaking change, but an error would break real applications in practice. In future, once people have had chance to fix the warnings, we could maybe increase the severity to make it an error.
The warnings should be visible in the console for anyone using the SFC Playground or a browser-based compiler. For a standard Vite setup, the warning won't be shown in the browser, it'll only appear in the terminal running Vite.
SFC Playground example
Screenshot of Vite: