Skip to content
This repository was archived by the owner on Jan 18, 2022. It is now read-only.

Conversation

@diogoazevedos
Copy link

@diogoazevedos diogoazevedos commented Oct 18, 2016

<style lang="scss">
  ...
</style>

@GregPeden
Copy link

I'm pretty sure this would break the Gulp compile. The problem is not that 'lang="sass"' is in the tag, it's that the PHPstorm debug complains that the newer SCSS syntax is wrong when it's not. If you use SCSS syntax and include 'lang="sass"' it will compile but 'lang="scss"' will not.

@ZhihaoLau
Copy link

This works for me! pls pass the PR

@ZhihaoLau
Copy link

ZhihaoLau commented Nov 17, 2016

With 'lang="sass"' and scss code together also can be compiled. But my Atom don't recognize scss syntax with 'lang="sass"' tag. This PR solve my problem.

@GregPeden
Copy link

Can you compile with lang="scss"? I can't

@diogoazevedos
Copy link
Author

@SirLamer With this changes you can compile using both languages scss and sass, but without how are using Atom with Vue will see an syntax error.

@shealan
Copy link

shealan commented Nov 18, 2016

This fixes the error for me 👍

@diogoazevedos
Copy link
Author

@yyx990803 can you resolve this PR?

@ZhihaoLau
Copy link

ZhihaoLau commented Nov 20, 2016

@diogoazevedos

Nope.. Just find out a better solution. In Laravel's docs, there's one line saying:

If you'd like to leverage more of Webpack's functionality, Elixir will read any webpack.config.js file that is in your project root and factor its configuration into the build process.

That means you can create webpack.config.js file in your project root, and re-run npm run dev.

module.exports = {
  vue: {
    loaders: {
      js: 'buble-loader',
      scss: 'vue-style!css!sass'
    }
  }
}

Because laravel-elixir-vue-2 will merge your webpack config using Elixir.webpack.mergeConfig.
Problem solve, pls close this PR. @yyx990803

@diogoazevedos
Copy link
Author

@ziolau This works like a charm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants