PHP Creating a file on the server via controller

Question

I have the following code but it does not seem to be creating a folder at all.

Should I be using is_dir instead of file_exists?

        $location = $_SERVER['DOCUMENT_ROOT'].'/_assets/quote/uploads/';

        $folderName = $this->quote->getCompanyDetails()->companyName;
        $folderName = str_replace(" ", "_", $folderName);
        $folderName = strtolower($folderName);

        if(!file_exists($folderName))
        {   
            mkdir($location.$folderName, 0777);

        }else{

marknatividad · Accepted Answer · 2012-04-10 05:08:28Z

2

Use

if (!file_exists($dir) && !is_dir($dir)) {
    mkdir($location.$folderName, 0777);
}

answered Apr 10, 2012 at 5:08

marknatividad

6308 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Corbin Over a year ago

That's redundant. If a file exists, mkdir won't overwrite it. And is_dir will return true if the directory exists. Therefore, you can just use one of them.

Jess McKenzie Over a year ago

@corbin what would you recommend using?

Corbin Over a year ago

@JessMcKenzie Depends what your end goal is. Would you want to delete a file and create a directory in its place? If you just want to create a directory if it doesn't exist and you know that a file with the desired name will never exist, then I would go with is_dir. Really they're both functionally equivalent in that situation. When it would matter would be if a file may actually exist that has desired directory name.

Jess McKenzie Over a year ago

@cobin I am just trying to create an empty folder the upload comes in the else statement

Valeriy Gorbatikov · Accepted Answer · 2012-04-10 05:17:55Z

0

is_dir function only detect if defined path is folder. Probably, you have not sufficient rights to create folder. Try to use

<?php
if (is_writable($dir)) {
echo "Path is writable";
}
?>

to detect if really your path is writable.

answered Apr 10, 2012 at 5:17

Valeriy Gorbatikov

3,5291 gold badge17 silver badges9 bronze badges

Comments

metalfight - user868766 · Accepted Answer · 2012-04-10 05:17:59Z

0

It seems to be permission issue. Check do you have write permission in the directory where you are using mkdir.

Also use

echo $location.$folderName ;

to check it's happening at right place.

Hope this help.

answered Apr 10, 2012 at 5:17

metalfight - user868766

2,7601 gold badge17 silver badges21 bronze badges

Collectives™ on Stack Overflow

PHP Creating a file on the server via controller

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related