Initialising Instance Variables

Question

I was wondering what is the difference between the following and which way is the best way of doing it:

public class ClassA
{
    public ClassB myClass = new ClassB();

    public void MethodA()
    {
         myClass.SomeMethod();
    }
}

Or this:

public class ClassA
{
    public ClassB myClass = null;

    public ClassA()
    {
        myClass = new ClassB();
    }        

    public void MethodA()
    {
         myClass.SomeMethod();
    }
}

Edit

I removed IDisposable, bear in mind this was just an example, my point was just to see which way is better at instantiating instance variables

SLaks · Accepted Answer · 2012-04-11 17:39:31Z

4

Neither.

You should not implement IDisposable unless you have actual resources to dispose.
Simply setting fields to null in Dispose() is almost always useless.

To answer the question, it doesn't matter.
You should use the shorter, simpler first version.

answered Apr 11, 2012 at 17:39

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

CallumVass Over a year ago

So both examples, ClassB will be disposed by the garbage collector?

SLaks Over a year ago

No; the garbage collector doesn't dispose anything. They will be collected by the GC.

SLaks Over a year ago

@BiffBaffBoff: They actually compile to identical IL.

Grant Thomas · Accepted Answer · 2012-04-11 17:46:32Z

1

Is ClassB disposable? If so then you should be disposing of it rather than setting it to null. Does ClassA have any other resources that are disposable? If so, they should be disposed. If there is nothing to dispose of, then you need not implement IDisposable.

Just because ClassA implements disposal does not mean just anything can be disposed in that context. The thing has to implement it too. Further, if you were actually implementing IDisposable then there is a recognised pattern for doing so.

edited Apr 11, 2012 at 17:46

answered Apr 11, 2012 at 17:41

Grant Thomas

45.1k10 gold badges88 silver badges129 bronze badges

Comments

Servy · Accepted Answer · 2012-04-11 18:07:48Z

1

The code in your first example will be converted into code in your second example by the compiler. When you initialize instance variables where they are defined it actually moves that initialization to the top of the constructor (or some other method just before the constructor, which is effectively the same thing).

There are some times where you can't do the first case (what you're assigning is just too complex, or relies on data that doesn't exist yet). But other than that, it's just personal preference. It's generally best to avoid mixing the two techniques in the same class though, as it's a bit harder to follow for a reader.

answered Apr 11, 2012 at 18:07

Servy

204k27 gold badges347 silver badges470 bronze badges

Collectives™ on Stack Overflow

Initialising Instance Variables

Edit

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

Edit

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related