Why does this onclick event set in Javascript not fire?

Question

The code is simple:

var td1 = document.createElement("td");
td1.id="td_radio_"+nr_int+"_"+nr_var2;
td1.style.border = "0";
td1.style.width = "5%";
td1.onclick="adaugare_varianta_simplu(\'"+nr_int+"\',\'"+nr_var2+"\');";

but the function doesn't fire when I click the cell; what am I doing wrong? I'm not using bind because later on there's gonna be a removeAttr working on it so I want it set up as an attribute.

GillesC · Accepted Answer · 2012-04-12 12:13:19Z

2

You are assigning a string as event handler so it can not be executed, below is more what you are after I think.

var td1 = document.createElement("td");
td1.id="td_radio_"+nr_int+"_"+nr_var2;
td1.style.border = "0";
td1.style.width = "5%";
td1.onclick = function() {
    adaugare_varianta_simplu(nr_int,nr_var2);
};

answered Apr 12, 2012 at 12:13

GillesC

10.9k3 gold badges42 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bogdan Over a year ago

This worked, thanks. I thought it should work like any other attribute, i was wrong.

Elliot Bonneville · Accepted Answer · 2012-04-12 12:10:21Z

2

Think you need this:

td1.onclick="function(){adaugare_varianta_simplu(\'"+nr_int+"\',\'"+nr_var2+"\');}";

You have to wrap the event in a function.

answered Apr 12, 2012 at 12:10

Elliot Bonneville

53.6k24 gold badges101 silver badges125 bronze badges

Collectives™ on Stack Overflow

Why does this onclick event set in Javascript not fire?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related