Inserting data into two separate tables using PHP

Question

I am trying to insert data into two different tables in the same database, if I try to insert it into one database, it works, however, once I insert the second query into my code ($desc_query) it won't update any table.

Here is my code:

    $name= strip_tags($_POST['name']);
    $l_name= strip_tags($_POST['last_name']);

    $c_id = strip_tags($_POST['company_id']);
    $a_d = strip_tags($_POST['add_description']);
    $d_t = strip_tags($_POST['desc_text']);

$connect = mysql_connect('localhost','id','pass') or die ("couldn't connect!"); 

mysql_select_db('database_db') or die('could not connect to database!');   

//inserting names

$job_query=mysql_query("INSERT INTO names VALUES ('', '$name', '$l_name')");

    //inserting a new description if needed. (this is the part that ruins everything)
if($a_d == 'true'){
    $desc_query=mysql_query("INSERT INTO descriptions VALUES ('','$c_id','$d_t')");
}

your code is very incomplete, where do all the variables com from? — Andreas Linden
– Andreas Linden, Commented Apr 20, 2012 at 21:51
@zolex- i guess, there is some error with the value contained in the variable of if condition. — Sujit Agarwal
– Sujit Agarwal, Commented Apr 20, 2012 at 21:52
The values doesn't really matter.... anyways, i will upload where i get them from, most of them are from $_POST — Baruch
– Baruch, Commented Apr 20, 2012 at 21:52
try something like die(mysql_error()); after the first and then second query and see the output; if it's not empty there's an error with your sql, maybe your values are not escaped or something... — jadkik94
– jadkik94, Commented Apr 20, 2012 at 21:56

Justin Pearce · Accepted Answer · 2012-04-20 22:10:01Z

1

You might be having an issue where some characters (like ' and ") are breaking the SQL query (not to mention opening your application up for SQL injection attacks).

I would recommend sanitizing all user provided data like so:

$name = mysql_real_escape_string(strip_tags($_POST['name']), $connect);
$l_name = mysql_real_escape_string(strip_tags($_POST['last_name']), $connect);
...
$d_t = mysql_real_escape_string(strip_tags($_POST['desc_text']), $connect);

Always operate under the assumption that the user is going to enter something outlandish or malicious that may (or may not) break your SQL.

answered Apr 20, 2012 at 22:10

Justin Pearce

5,1172 gold badges26 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DigiDamsel · Accepted Answer · 2012-04-20 22:01:47Z

0

Have you tried to echo out the queries and then to run them directly on the database?

Without any more information about the database we can't really tell if the queries themselves are valid.

answered Apr 20, 2012 at 22:01

DigiDamsel

1066 bronze badges

Collectives™ on Stack Overflow

Inserting data into two separate tables using PHP

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related