Implementation of Stack by linked list

Question

I am getting below error message. Could not able to solve it. Googled a lot. Finally thought of to put it here.

enter image description here

#include <stdio.h>
#include <stdlib.h>
#include <malloc.h>
int stop;
struct stack
{
  int data;
  struct stack *next;
};
typedef struct stack *node, *top;
//typedef struct stack *top;
void push()
{
    int i;
    struct stack *x;
    x = malloc(sizeof(struct stack));
    printf("\n Enter the element your want to insert");
    scanf("%d", &i);
    x->data = i;
    x->next = top;
    top = x;
}
void pop()
{
    int i;
    if(top == NULL)
    {
        printf("\nStack is empty\n");
    }
    else{
    i = top->data;
    free(top);
    top = top->next;

    }
}
void display()
{
    if(node != NULL)
    {
        printf("%d ", node->data);
        node = node->next;
    }

}
int main()
{
    int ch;
    while(1)
    {
        printf("\nEnter your option \n1. Insert(Push) \n2. Delete(Pop) \n3. Display  : \n");
        scanf("%d", &ch);
        switch(ch)
        {
            case 1:
                    push();
                    break;
            case 2:
                    pop();
                    break;
            case 3:
                    display();
                    break;
            default:
                    printf("Invalid Entery, Try Again");
        }
    }
return 0;
}

giorashc · Accepted Answer · 2012-04-24 13:47:27Z

5

remove typedef and all will be fine.

answered Apr 24, 2012 at 13:47

giorashc

13.7k3 gold badges38 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

chrisaycock · Accepted Answer · 2012-04-24 13:48:30Z

3

You don't want a new type:

typedef struct stack *node, *top;

Instead, you want a new variable:

struct stack *node, *top;

answered Apr 24, 2012 at 13:48

chrisaycock

38.1k15 gold badges94 silver badges128 bronze badges

Comments

Sergey Kalinichenko · Accepted Answer · 2012-04-24 13:48:08Z

1

You cannot combine variable declarations with typedef. If you would like to create an alias for struct stack and call it simply stack, modify your code as follows:

struct stack {
    int data;
    struct stack *next;
};
typedef struct stack stack;
stack *node, *top;

answered Apr 24, 2012 at 13:48

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

3 Comments

Deverill Over a year ago

Wow, that's confusing. In the last line does stack refer to struct stack or to typedef struct stack stack ? Maybe another name for the alias would be clearer.

Sergey Kalinichenko Over a year ago

@Deverill It's the same thing, but on the last line struct stack is referenced by its typedef-ed alias, not by its tag. Using aliases identical to tags is a relatively common practice.

Deverill Over a year ago

Maybe I'm just getting old and easily confused. :) Thanks for the explanation.

Collectives™ on Stack Overflow

Implementation of Stack by linked list

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related