php pdo insert statement not working

Question

I have a site on host gator. I can connect with my pdo statement but the statement for the insert doesnt seem to work. Right now I have defined the values but i plan to use variabled pulled from a $_POST from a form on the previous page.

<?php

/*** mysql hostname ***/
$hostname = 'xxx.xxx.xxx.xxx';

/*** mysql username ***/
$username = 'pressgym_admin';

/*** mysql password ***/
$password = '*******';  <-started out on purpose

try {
$dbh = new PDO("mysql:host=$hostname;dbname=pressgym_press", $username, $password);
/*** echo a message saying we have connected ***/
$qry = $dbh->prepare('INSERT INTO contact (Name, Email Address, Message, Date) VALUES (?, ?, ?, ?');
$qry->execute(array('Brandon', '[email protected]', 'test message', '3.12.12'));

echo 'entry succesfull';

}
catch(PDOException $e)
{
echo $e->getMessage();
}
?>

   describe contact;
   Name varchar(255)    NO  PRI     
   EmailAddress varchar(255)    NO          
   Message  longtext    NO          
   Date varchar(255)    YES

Enable PDO Exceptions with $dbh->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); — Mike B
– Mike B, Commented Apr 24, 2012 at 17:19
I would change the host name to something fake. If that's a real IP, you're just asking for abuse.... — Kris.Mitchell
– Kris.Mitchell, Commented Apr 24, 2012 at 17:20
@MikeB 's comment fixed the issue I had. Disabling exceptions by default seems like an awful design decision. It creates a scenario where PDO is the cryptic wife ("No, it's fine.") and PHP is the oblivious husband ("Fine? Well all right! Onto the next thing..."). — aaaantoine
– aaaantoine, Commented Jan 20, 2015 at 4:01

eggyal · Accepted Answer · 2012-04-24 17:23:15Z

5

The SQL syntax in your prepare command contains errors:

qry = $dbh->prepare('INSERT INTO contact (Name, Email Address, Message, Date) VALUES (?, ?, ?), ?');

should be

qry = $dbh->prepare('INSERT INTO contact (Name, `Email Address`, Message, Date) VALUES (?, ?, ?, ?)');

edited Apr 24, 2012 at 17:23

answered Apr 24, 2012 at 17:18

eggyal

127k18 gold badges220 silver badges244 bronze badges

Sign up to request clarification or add additional context in comments.

13 Comments

Brandon Braner Over a year ago

wow you were quick ;) i saw that after i posted it, still doesnt work

eggyal Over a year ago

@BrandonBraner: I've updated my answer to reflect that the identifier for the Email Address column needs to be quoted in order to handle the space it contains.

Ibrahim Azhar Armar Over a year ago

aaw my bad. i didn't notice the space, and assumed it to be another column

eggyal Over a year ago

@IbrahimAzharArmar: Credit where it's due, I only noticed it after reading your answer! +1

Ibrahim Azhar Armar Over a year ago

+1 for the answer. and @Brandon Braner, try not to use space ( ) in column names.

|

Ibrahim Azhar Armar · Accepted Answer · 2012-04-24 17:29:16Z

2

you have a syntax error. the following line

$qry = $dbh->prepare('INSERT INTO contact (Name, Email Address, Message, Date) VALUES(?, ?, ?), ?');

should be

$qry = $dbh->prepare('INSERT INTO contact (Name, Email Address, Message, Date) VALUES (?, ?, ?, ?)');

Update:

your column name Email Address contains a space escape it by using proper quote identifier like

INSERT INTO contact (Name, `Email Address`, Message, Date) VALUES (?, ?, ?, ?)'

edited Apr 24, 2012 at 17:29

answered Apr 24, 2012 at 17:18

Ibrahim Azhar Armar

25.8k36 gold badges136 silver badges213 bronze badges

Collectives™ on Stack Overflow

php pdo insert statement not working

2 Answers 2

13 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

13 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related