Inner class object into Outer class constructor into c#

Question

Can we create an object of the inner class in the constructor of the outer class into C#? Is it legal?

public class Outer
{
    public Inner InnerObj {get; set; }

    public Outer()
    {
        Inner inner = new Inner();
    }

    public Outer(Inner inner)
    {
        InnerObj = inner;
    }

    public class Inner
    {
    }
}

for Java I take the reference from below link: Can we create an object of the inner class in the constructor of the outer class?

My colleague said this is not possible in C# and it's totally illegal. Please guide me.

You should listen to the compiler, not your colleague and for such a trivial matter probably not us. It's not difficult to see that it compiles just fine. — Jon
– Jon, Commented Apr 25, 2012 at 8:07
I tried it, I am not getting any error, but my colleague said it's not Object-Oriented and totally illegal — Saroop Trivedi
– Saroop Trivedi, Commented Apr 25, 2012 at 8:08
Does (s)he think you'll go to prison (aha-ha-ha)... I think your colleague might need to be kicked upstairs — Andras Zoltan
– Andras Zoltan, Commented Apr 25, 2012 at 8:54

juergen d · Accepted Answer · 2012-04-25 07:57:35Z

2

It is possible if you declare the Inner class public

public class Inner { }

answered Apr 25, 2012 at 7:57

juergen d

205k40 gold badges305 silver badges377 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Saroop Trivedi Over a year ago

Yes, my inner class is public class.

skyfoot · Accepted Answer · 2012-04-25 07:57:44Z

1

The problem with your code is how does the calling code know what Inner obj is as it is not accessible outside of the outer class.

A better design would be to have the inner class outside of the outer class so that its not so tightly coupled. Also pass the object against an interface.

public class Outer
{        
    public Outer(IInner inner)
    {

    }
}

public class Inner: IInner
{
}

public Interface IInner
{
}

answered Apr 25, 2012 at 7:57

skyfoot

20.7k10 gold badges52 silver badges71 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 10:26:52Z

1

Sure, it's possible. Technically, there is nothing wrong with your code (if you make your inner public or your outer class internal).

Note, however, that this is not recommended to use public nested classes, see this question for details:

C#, is it okay to use nested classes for logical structure?

edited May 23, 2017 at 10:26

CommunityBot

11 silver badge

answered Apr 25, 2012 at 8:07

Heinzi

173k61 gold badges386 silver badges555 bronze badges

Comments

abatishchev · Accepted Answer · 2012-04-25 08:02:39Z

0

That's illegal (leads to compiler error) until Inner is not public.

After marking as public it's absolutely legal.

answered Apr 25, 2012 at 8:02

abatishchev

101k88 gold badges304 silver badges443 bronze badges

2 Comments

Saroop Trivedi Over a year ago

Inner class in public class. Now is it illegal.

abatishchev Over a year ago

@sarooptrivedi: Now everything is fine. The same exists in FCL itself, e.g. Dictionary<K,V>+KeyCollection (you can check it out using Reflector)

Collectives™ on Stack Overflow

Inner class object into Outer class constructor into c#

4 Answers 4

1 Comment

Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related