Getting Uncaught TypeError: Cannot read property 'left' of null in js

Question

I have this jquery code that goes through the nav bar and the selected link has a box around it. It only works on the middle link, none of the others. Any ideas? Thanks in advance.

navigation arrow starts
var $el, leftPos, newWidth,
    $mainNav = $("#nav");

$mainNav.append("<li id='magic-line'></li>");
var $magicLine = $("#magic-line");

$magicLine
    .width($(".current_page_item").width())
    .css("left", $(".current_page_item a").position().left)
    .data("origLeft", $magicLine.position().left)
    .data("origWidth", $magicLine.width());

//scroll arrow

function update_location(){
    $el = $('#nav').children('li.current');
    leftPos = $el.position().left;
    newWidth = $el.width();
    $('#nav li:nth-child(4) a').addClass('button-style');
    if(window.top.scrollY == 0)
    {
        setTimeout(function(){
        $magicLine.stop().animate({
            left: 8,
            width: 355
        });},1000);
        $('#nav li:nth-child(4) a').removeClass('button-style');

    }
    else
    {
        setTimeout(function(){
        $magicLine.stop().animate({
            left: leftPos,
            width: newWidth
        });},1000);
    }
}

$('#magic-line').css('left', '-15px', 'width','411px');
$(window).scroll(function(){
    update_location();
});

    <div class="navbar-fixed-top navbar" >
    <div class="navbar-inner">
        <div class="container">
            <ul class="nav nav-pills pull-right" id="nav">
                <li class="current_page_item" style="width: 355px;"><a href="#home" class="logo" style="display:block; width: 355px;"><img src="images/logo.jpg" class="current_page_item" width="355" alt="" /></a></li>
                <li><a href="#vision">VISION</a></li>
                <li><a href="#services">SCHOOLS</a></li>
                <li><a href="#apply">REQUEST AN EVALUATION</a></li>
                <li><a href="#how-it-works">HOW IT WORKS</a></li>
                <li><a href="#contact-us">CONTACT US</a></li>
            </ul>
        </div>
    </div>
</div>

Getting the error after leftPos = $el.position().left; under function update_location()

The problem is that $el = $('#nav').children('li.current'); contains zero elements. Hence, .position() is null, and your error is observed. Another note: Ever heard about variable declarations? When all var prefixes is omitted, the variables are defined in the global scope. — Rob W
– Rob W, Commented Apr 26, 2012 at 18:01
Because that's defined behaviour in jQuery.fn.position (source): if (!this[0]){return null;} - When there's no element, null is returned. — Rob W
– Rob W, Commented Apr 26, 2012 at 18:08

Adam Jenkins · Accepted Answer · 2012-04-26 18:01:29Z

2

I think you might be meaning to use the class current_page_item instead of current on this line:

$el = $('#nav').children('li.current');

$el is an empty jQuery object so el.position() is null and hence, cannot read property left of null.

answered Apr 26, 2012 at 18:01

Adam Jenkins

56.3k13 gold badges85 silver badges113 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Rodney Wilson Over a year ago

I replaced current with current_page_item and still hasn't changed. The error is gone though.

Rodney Wilson Over a year ago

It seems like when it loops through, it only assigns 'button-style' to the middle link and never takes it off and assigns to another link.

Irvin Dominin · Accepted Answer · 2014-05-02 12:02:13Z

1

Thats because:

$el = $('#nav').children('li.current');

returns null.

Try:

$el = $('#nav').children('li.current_page_item');

edited May 2, 2014 at 12:02

Irvin Dominin

31k9 gold badges83 silver badges114 bronze badges

answered Apr 26, 2012 at 18:03

daker

3,5383 gold badges45 silver badges56 bronze badges

Collectives™ on Stack Overflow

Getting Uncaught TypeError: Cannot read property 'left' of null in js

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related