Error when trying to upload file in PHP

Question

I am php page everything was working fine till today morning. Now the page is not uploading any selected file. All that I keep getting is the following error message:

Warning: move_uploaded_file(upload/BrainStream_2009_06_25_23041.zip) [function.move-uploaded-file]: failed to open stream: No such file or directory in C:\xampp\htdocs\vectorization\admin\jobs_edit.php on line 146

Warning: move_uploaded_file() [function.move-uploaded-file]: Unable to move 'C:\Documents and Settings\Admin\Local Settings\Temp\php1B2.tmp' to 'upload/BrainStream_2009_06_25_23041.zip' in C:\xampp\htdocs\vectorization\admin\jobs_edit.php on line 146 File could not be uploaded. Please select a valid file. File Name:BrainStream.zip

I have written following code:

$uplfile = $_FILES['uploadfile']['name'];   
$upltmp = $_FILES["uploadfile"]["tmp_name"];
if(!empty($uplfile))
{       
    $ext = explode(".", $uplfile);
    
    $upload_date = date("Y_m_d"); //use this variable to change file name to avoid conflict with same name files
    $upload_dir = "upload/";

    $file_name=$ext[0]."_".$upload_date."_".rand(0, getrandmax()).".".$ext[1];
    
    (move_uploaded_file($upltmp,$upload_dir.$file_name))
 }

I have XAMPP stack installed on my PC which is running WinXP, has 3 GB RAM and ample of Hard disk space.

No matter which size file I select it always give error.

What must be wrong in this code?

Just a quick note: If rand() is called without any arguments it behaves automatically the way you use it. — merkuro
– merkuro, Commented Jun 25, 2009 at 12:05
I see a security flaw: what if someone uploads a file named "filename.php.jpg" with some malicious php code inside? Instead of $ext[1] use $ext[count($ext)-1]. — Keeper
– Keeper, Commented Jun 25, 2009 at 12:08

phihag · Accepted Answer · 2009-06-25 11:56:24Z

2

Interesting syntax in the last line. The error indicates the problem is in that line and either the source file or destination directory is missing. Since the first one is automatically generated, make sure that C:\xampp\htdocs\vectorization\admin\upload exists and is writable.

answered Jun 25, 2009 at 11:56

phihag

289k75 gold badges475 silver badges489 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Yogi Yang 007 · Accepted Answer · 2009-06-25 12:03:27Z

1

@phihag,

Thanks for the hint. One of the new developer while studying the source had by mistake remove (../) in the $upload_dir variable assignment.

$upload_dir = "upload/"; //this is wrong

Actually it was set as

$upload_dir = "../upload/"; //this works but accidentally edited by another developer

What a lamer I am. I could not spot the problem.

Anyways thanks once one for your help to solve my problem.

answered Jun 25, 2009 at 12:03

Yogi Yang 007

5,27910 gold badges60 silver badges83 bronze badges

Comments

robjmills · Accepted Answer · 2009-06-25 11:55:58Z

0

looks like your problem could be that you're using forward slashes for your upload directory but on windows this would be a backslash, you also need to make sure that the upload directory is relative to the script. if not provide a full path.

A good tip to prevent the slashes issue is to use the DIRECTORY_SEPARATOR constant

answered Jun 25, 2009 at 11:55

robjmills

18.6k16 gold badges81 silver badges124 bronze badges

2 Comments

phihag Over a year ago

Windows' directory separators are \ and /, so that's not a problem. Generally, use DIRECTORY_SEPARATOR in php or just /.

robjmills Over a year ago

oh really, i never work on windows but had always kinda assumed the reason for DIRECTORY_SEPARATOR was to prevent issues like this. If not, then whats its purpose?

Grouchal · Accepted Answer · 2009-06-25 11:59:25Z

0

One of two things - either

There is no upload directory
There is no file php1B2.tmp

answered Jun 25, 2009 at 11:59

Grouchal

9,8276 gold badges36 silver badges46 bronze badges

Comments

bobobobo · Accepted Answer · 2009-06-25 12:00:15Z

0

This may seem obvious, but be sure to double check your php.ini

file_uploads = On
upload_tmp_dir = "C:\xampp\tmp"
upload_max_filesize = 64M

answered Jun 25, 2009 at 12:00

bobobobo

67.9k67 gold badges272 silver badges375 bronze badges

Comments

James · Accepted Answer · 2009-06-25 12:01:14Z

0

What might be useful for you to do is a quick check to ensure the file has been uploaded successfully e.g.

switch ($_FILES["cv"]["error"])
{
    case UPLOAD_ERR_FORM_SIZE:
       // handle error
    case UPLOAD_ERR_INI_SIZE:
       // handle error
    case UPLOAD_ERR_PARTIAL:
       // handle error
    case UPLOAD_ERR_NO_FILE:
       // handle error
    case UPLOAD_ERR_CANT_WRITE:
       // handle error
}

Its a better way of handling the errors you may encounter when uploading files.

answered Jun 25, 2009 at 12:01

James

82.4k19 gold badges172 silver badges245 bronze badges

Collectives™ on Stack Overflow

Error when trying to upload file in PHP

6 Answers 6

Comments

Comments

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related