PHP echo $row['username'] not displaying the first username?

Question

I'm not really sure what the problem is here, I have a posts table that has a foreign key of userid and I want to pull their usernames from the users table based on that, it seems to pull them out fine but it won't display on the first post. My code is:

$query_therealuserid = 'SELECT users.username, users.userid, posts.userid, posts.created_at
FROM users, posts
WHERE users.userid = posts.userid
ORDER BY posts.created_at';

$therealuserid = mysql_query($query_therealuserid, $akaearthdb) or die(mysql_error());

and

<?php do { ?>
  <div id= "post">
    <?php if (stripos($row_rsjustpost['link'], ".png") !== false) {?>
            <img src="<?php echo $row_rsjustpost['link']; ?>" id="postImage" alt="Broken Link">
            <?php }?>
    <?php if (stripos($row_rsjustpost['link'], ".gif") !== false) {?>
            <img src="<?php echo $row_rsjustpost['link']; ?>" id="postImage" alt="Broken Link">
            <?php }?>
    <?php if (stripos($row_rsjustpost['link'], ".jpg") !== false) {?>
            <img src="<?php echo $row_rsjustpost['link']; ?>" id="postImage" alt="Broken Link">
            <?php }?>
    <?php if (stripos($row_rsjustpost['link'], ".jpeg") !== false) {?>
            <img src="<?php echo $row_rsjustpost['link']; ?>" id="postImage" alt="Broken Link">
            <?php }?> 

    <a href="<?php echo $row_rsjustpost['link']; ?>"><?php echo $row_rsjustpost['title']; ?></a>
    <br/>
    <?php echo $row_rsjustpost['text']; ?>
    </p>
    <br />

            <?php 
            do {
            if ($whileLoopCounter0!=$whileLoopCounter1){break;}
        ?>By: <?php echo $row['username'];
        echo "<br />";
            $whileLoopCounter1++;

            } while($row = mysql_fetch_array($therealuserid));
            ?>


  </div>
  <?php $whileLoopCounter0++; ?>
  <?php } while ($row_rsjustpost = mysql_fetch_assoc($rsjustpost)); ?>
</div>

when I pull up the page I get all the posts but the first one doesn't have a username and the usernames are all pushed down one post. The first post has a postid of 2, if I create a new post with a postid of 1 and a userid it shows up at the top without a username and the others usernames are moved up so that they are corect.

Please stop writing new code with the ancient mysql_* functions. They are no longer maintained and community has begun the deprecation process. Instead you should learn about prepared statements and use either PDO or MySQLi. If you care to learn, here is a quite good PDO-related tutorial. — Madara's Ghost
– Madara's Ghost, Commented May 8, 2012 at 20:07
@Truth Sorry about that I'm just getting started and I'm following some somewhat old tutorials as well as using dreamweaver's tools to write some of the code. I'll look into PDO and MySQLi, thanks. — Aaron Robeson
– Aaron Robeson, Commented May 9, 2012 at 14:04

Musa · Accepted Answer · 2012-05-08 20:09:22Z

3

That's because you use a do-while loop, the $row = mysql_fetch_array($therealuserid) is executed at the end of the loop, why not use a regular while loop.

answered May 8, 2012 at 20:09

Musa

97.9k17 gold badges123 silver badges144 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Aaron Robeson Over a year ago

I was avoiding it because even if the break was called it would count as if it had displayed a username, so it would only display every other one. (Tushar Dhoot fixed it for me)

Tushar · Accepted Answer · 2012-05-08 20:42:30Z

1

You're currently using a do-while loop, so first the do block is executed and then the while block is evaluated only after the 1st execution of the do block.

Use this instead:

while ($whileLoopCounter0==$whileLoopCounter1) {
   $row = mysql_fetch_array($therealuserid);
   if ($row){
 ?>
 By: 
 <?php 
      echo $row['username'];
      echo "<br />";
      $whileLoopCounter1++;
    }
}

edited May 8, 2012 at 20:42

answered May 8, 2012 at 20:11

Tushar

8,05934 silver badges39 bronze badges

3 Comments

Aaron Robeson Over a year ago

I tried that but it counts as having gone through an iteration even if the if statement breaks out of the loop, so it only displays every other username.

Aaron Robeson Over a year ago

It worked! Thank you, I've been trying to get this to work for like a week now. :)

Tushar Over a year ago

Glad I could help! Take a look at the PDO suggestion above, it's very good advice.

Travesty3 · Accepted Answer · 2012-05-08 20:14:59Z

0

Looks like you are fetching the username after you increment the loop counter. The user name is pulled after the loops is one, so the first row will be empty because that data doesn’t exist yet.

There are a lot of other things though that you’re doing that are just wasting effort though. Try tossing the results into an object and using foreach($result as $key=>$value) or foreach($result as $item) if you do not need the key instead.

edited May 8, 2012 at 20:14

Travesty3

14.5k7 gold badges64 silver badges103 bronze badges

answered May 8, 2012 at 20:11

M Noivad

1068 bronze badges

Collectives™ on Stack Overflow

PHP echo $row['username'] not displaying the first username?

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related