Why when i load page it runs function and alerts me "function run" i did not call it nowhere i need function to only trigger on element click.
<script type="text/javascript">
open_close = function() {
alert("function run");
//some code ...
}
window.onload = function() {
//some code ...
var myButton = document.getElementById('button');
myButton.onclick = open_close();
//some code ...
}
</script>
Here's jfiddle demo http://jsfiddle.net/ayeBP/
Ah, but you did run it:
myButton.onclick = open_close();
Parentheses invoke a function. Use this instead:
myButton.onclick = open_close;
Better still (click through for legacy IE support):
myButton.addEventListener('click', open_close);
Okay this was simplidied function i need to actually pass 2 variables to it e.g.
myButton.onclick = open_close(var1,var2);
You still cannot use parentheses as you keep trying to do, because parentheses invoke the function. Use an anonymous function:
myButton.onclick = function () {
open_close(var1, var2);
};
// or, even better,
myButton.addEventListener('click', function () {
open_close(var1, var2);
});
$("myButton").on("click",open_close);
myButton.onclick = open_close(var1,var2); I know someone will mention jquerry i just knew it...
myButton.onclick = open_close; worked even on IE 6.0 i just checked on virtual PC so i don't see problem there. Reason is i like to have pure code that i wrote and no extra files to download. I am minimalist i guess.Replace open_close() with open_close
Using parentheses here will invoke the function immediately and assign the return value of it to myButton.onclick
myButton.onclick = open_close(var1,var2);