Using .replace in $.each

Question

New to jquery. I already got this running in javascript but am switching to jquery so I can use .each. Is there some special rule preventing me from using JavaScripts .replace inside jQuerys .each?

    var jse_sanitized_title = "";
    var jse_article_title = "";

    var jse_article_titles = $('.jse_article_title');

    $.each(jse_article_titles, function(i) {

    jse_article_title = jse_article_titles[i].innerHTML;

            //error for this says jse_article_titles[i].replace is not a function
    jse_sanitized_title = jse_article_titles[i].replace(/ /g,"_");

})

EDIT: The purpose of the replace is to replace spaces with underscores.

You override the string in each loop! what are you trying to do? — gdoron
– gdoron, Commented May 14, 2012 at 18:09
Instead of $.each(jse_article_titles, you can do jse_article_titles.each(. — gen_Eric
– gen_Eric, Commented May 14, 2012 at 18:10
You can simply use .text and update all the matching selector. See DEMO >> jsfiddle.net/skram/WhJGG << Updated answer — Selvakumar Arumugam
– Selvakumar Arumugam, Commented May 14, 2012 at 18:18

gdoron · Accepted Answer · 2012-05-14 18:11:16Z

3

$.each(jse_article_titles, function() {
    jse_article_title = this.innerHTML;
    jse_sanitized_title = jse_article_title.replace(/ /g,"_");
});

After the update, it looks like you want to do something like this:

$('.jse_article_title').each(function(){
    this.innerHTML = this.innerHTML.replace(/ /g,"_");
});

There is another way with jQuery:

$('.jse_article_title').html(function(index, old){
    return old.innerHTML.replace(/ /g,"_");
});

edited May 14, 2012 at 18:11

answered May 14, 2012 at 18:05

gdoron

151k59 gold badges302 silver badges376 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Kevin Nelson Over a year ago

+1 for .html() method. That seems like the most appropriate way to do it the "jquery way".

Jonathan Eckman Over a year ago

If I was replacing with underscores then putting the string right back where I got it from this would be the best answer.

Matthew Flaschen · Accepted Answer · 2012-05-14 18:05:01Z

2

Presumably you mean:

    $.each(jse_article_titles, function(i) {

    jse_article_title = jse_article_titles[i].innerHTML;

            //error for this says jse_article_titles[i].replace is not a function
    jse_sanitized_title = jse_article_title .replace(/ /g,"_");
    jse_article_titles[i].innerHTML = jse_sanitized_title;

})

If you have not already declared jse_article_title, put a var here, like:

var jse_article_title = jse_article_titles[i].innerHTML;

Note that you have to reassign it at the end. Finally, there are no special rules like this. jQuery is just a library.

answered May 14, 2012 at 18:05

Matthew Flaschen

286k53 gold badges523 silver badges554 bronze badges

1 Comment

Jonathan Eckman Over a year ago

My mistake. I did declare all variables in my code but I forgot to include them in my example. You get the check.

Selvakumar Arumugam · Accepted Answer · 2012-05-14 18:16:08Z

1

EDIT: The purpose of the replace is to replace spaces with underscores.

Updated to use .text() function to set replace all spaces with _

DEMO

$('.jse_article_title').text(function () {
    return this.innerHTML.replace(/ /g, '_');
});

May be you need

jse_sanitized_title = jse_article_title.replace(/ /g,"_"); 
//using the jse_article_title

or

jse_sanitized_title = jse_article_titles[i].innerHTML.replace(/ /g,"_");

or Using jQuery,

jse_sanitized_title = $(this).text().replace(/ /g, "_");

edited May 14, 2012 at 18:16

answered May 14, 2012 at 18:05

Selvakumar Arumugam

79.9k15 gold badges123 silver badges139 bronze badges

Comments

Belladonna · Accepted Answer · 2012-05-14 18:06:40Z

0

Try this:

$.each(jse_article_titles, function() {

    jse_article_title = $(this).html();

    jse_sanitized_title = jse_article_title.replace(/ /g,"_");

})

answered May 14, 2012 at 18:06

Belladonna

3,8622 gold badges26 silver badges33 bronze badges

3 Comments

Belladonna Over a year ago

Would you mind explaining why? Is it because it's an unnecessary abstraction that does the same thing?

gen_Eric Over a year ago

@LittleBigBot: Because using the native DOM properties is slightly faster than calling the jQuery function to do that for you.

gdoron Over a year ago

@Vega. Roket, you're right... stackoverflow.com/q/10433014/601179 slightly

Kevin Nelson · Accepted Answer · 2012-05-14 18:30:34Z

0

To do it the way you were trying (with innerHTML) you need to reference the node with get()...you'd need to do this:

jse_article_titles.get(i).innerHTML

However, you should be able to shorten that a bit.

$('.jse_article_title').each( function() {
    $(this).html( $(this).html().replace(/ /g,"_") );
});

// or

$('.jse_article_title').each( function() {
    this.innerHTML = this.innerHTML.replace(/ /g,"_");
});

// whichever floats your boat

[EDIT]: Sorry, I was wrong about needing .get(). jse_articles_titles[i] is perfectly valid as long as the number is not negative, which is unlikely.

edited May 14, 2012 at 18:30

answered May 14, 2012 at 18:14

Kevin Nelson

7,7134 gold badges34 silver badges42 bronze badges

Collectives™ on Stack Overflow

Using .replace in $.each

5 Answers 5

2 Comments

1 Comment

Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

1 Comment

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related