Entity Framework - ASP MVC Models - Relationships

Question

I have some Models in my app like so:

public class Enquiry
{
    [Key]
    [Required]
    public int EnquiryID { get; set; }

    [Required]
    [Display(Name = "Enquiry Type:")]
    public virtual int EnquiryTypeID { get; set; }
    public virtual EnquiryType EnquiryType { get; set; }

    public virtual ICollection<DeliveryType> DeliveryTypes { get; set; }

}

public class EnquiryType
{
    [Key]
    public int EnquiryTypeID { get; set; }

    [Display(Name = "Enquiry Type:")]
    [MaxLength(100)]
    public string EnquiryTypeName { get; set; }
}

public class DeliveryType
{
    [Key]
    public int DeliveryTypeID { get; set; }
    public int EnquiryID { get; set; }
    public string DeliveryName{ get; set; }
}

So the jist of it is. I have an Enquiry, each Enquiry has a Type of Enquiry (Sales, General, Technical etc..) so this is a One-to-One relationship. Each Enquiry can then have multiple DeliveryTypes attached to it, so its a One-to-Many relationship.

My question is, have I set this up correctly with my models above? Am I missing something? Do I have virtual's in the wrong place/not set up correctly? Do I need EnquiryID to be in my DeliveryType model?

Do you have any problems with it?

Romias
– Romias

2012-05-15 20:14:53 +00:00
Commented May 15, 2012 at 20:14 — Romias
– Romias, Commented May 15, 2012 at 20:14

MattSavage · Accepted Answer · 2012-05-15 20:20:49Z

1

You do not need EnquiryID on the DeliveryType model. But, the EnquiryTypeID on the Enquiry should not be virtual. I would set it up like this:

public class Enquiry
{
    [Key]
    [Required]
    public int EnquiryID { get; set; }

    [Required]
    [Display(Name = "Enquiry Type:")]
    public int EnquiryTypeID { get; set; }

    public virtual EnquiryType EnquiryType { get; set; }
    public virtual ICollection<DeliveryType> DeliveryTypes { get; set; }

}

public class EnquiryType
{
    [Key]
    public int EnquiryTypeID { get; set; }

    [Display(Name = "Enquiry Type:")]
    [MaxLength(100)]
    public string EnquiryTypeName { get; set; }
}

public class DeliveryType
{
    [Key]
    public int DeliveryTypeID { get; set; }
    public string DeliveryName{ get; set; }
}

answered May 15, 2012 at 20:20

MattSavage

7781 gold badge7 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

CallumVass Over a year ago

Thanks for the response. Out of curiosity, why would I remove the EnquiryID from DeliveryType. How would the relationship then be set up if DeliveryType has no idea which Enquiry it is attached too?

MattSavage Over a year ago

I guess I'm confused about how you are using DeliveryTypes. Can a single DeliveryType be associated with many Enquiries, or will each DeliveryType only belong to a single Enquiry? If the latter is true, then you are correct - you will need to add EnquiryId to the properties of DeliveryType.

CallumVass Over a year ago

Yeah that latter is true, sorry for the confusion! Thanks for the answer!

Collectives™ on Stack Overflow

Entity Framework - ASP MVC Models - Relationships

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related