Unable to Retrieve data from PHP class

Question

In the following code I am getting error: Undefined variable: base_url on line 27 and Cannot access empty property on line 27.

I need to echo the parameter http://google.com passed in get_url() from render().

<?php

$smart_url = new smart();

$smart_url -> get_url('http://google.com');

echo  $smart_url -> render();


 /**
 * Smart URL
 */

class smart {

private $base_url;

/**
 * 
 * @param string $url
 */
public function get_url($url) {
        $this -> $base_url = $url;

}


/**
 * @return string $base_url
 */
public function render() {
    return $this -> $base_url;


}

}


?>

This is a common PHP newbies mistake. Don't vote down on the question. And just btw as much is it asked as much easier it will be for newcomers to find their mistake. I asked a similar question myself an year ago. :D — Itay Grudev
– Itay Grudev, Commented May 19, 2012 at 7:27

romainberger · Accepted Answer · 2012-05-19 07:19:36Z

1

It's just a syntax error. You access your parameters this way:

 $this->base_url;

Without the $before the parameters' name

answered May 19, 2012 at 7:19

romainberger

4,5582 gold badges37 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

verisimilitude · Accepted Answer · 2012-05-19 07:19:53Z

1

Syntactically incorrect...
$this -> $base_url = $url;

Should be

$this->base_url = $url;

answered May 19, 2012 at 7:19

verisimilitude

5,1283 gold badges32 silver badges37 bronze badges

Comments

Itay Grudev · Accepted Answer · 2012-05-19 07:22:27Z

1

Short answer:

Use: $this->base_url

Long answer:

When you are accessing properties you don't need the dollar sign. Access them simply as that:

$this->base_url

The second one would access a class property with the name $base_url (the content of the variable).

This is a common mistake. Use the dollar sign only for declaring variables in this context:

protected $base_url;

answered May 19, 2012 at 7:22

Itay Grudev

7,5544 gold badges60 silver badges97 bronze badges

Comments

Bhavesh G · Accepted Answer · 2012-06-17 10:45:40Z

1

$this -> $base_url is wrong; no $ ,$this->base_url

edited Jun 17, 2012 at 10:45

Bhavesh G

3,0285 gold badges47 silver badges69 bronze badges

answered May 19, 2012 at 7:20

ninean

512 bronze badges

Collectives™ on Stack Overflow

Unable to Retrieve data from PHP class

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related