Android Listview displays last element in the ArrayList

Question

Hi my code only shows the last element of the ArrayList! Heres my code:

    ListView list = (ListView) findViewById(R.id.t1player_statsList);

    ArrayList<HashMap<String, String>> mylist = new ArrayList<HashMap<String, String>>();

    HashMap<String, String> map = new HashMap<String, String>();

    for(Player player : team1.getPlayers())
        map.put("player", player.getName()); 
        map.put("score", "0");
        mylist.add(map);


    SimpleAdapter mSchedule = new SimpleAdapter(this, mylist, R.layout.mylistrow,
                new String[] {"player", "score"}, new int[] {R.id.NameCell, R.id.ScoreCell});
    list.setAdapter(mSchedule);

i feel that its something to do with my for loop. can someone please help!! thanks in advance!

Lalit Poptani · Accepted Answer · 2012-05-19 11:53:29Z

6

You are creating only one instance of Hashmap that is over-writing all the values again and again and the last value remains. So, create a new instance inside for loop.

    HashMap<String, String> map;

    for(Player player : team1.getPlayers()){
        map = new HashMap<String, String>();
        map.put("player", player.getName()); 
        map.put("score", "0");
        mylist.add(map);
     }

answered May 19, 2012 at 11:53

Lalit Poptani

67.3k23 gold badges165 silver badges248 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Android Listview displays last element in the ArrayList

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related