How do I wrap link_to around some html ruby code?

Question

How do I wrap a link around view code? I can't figure out how to pass multiple lines with ruby code to a single link_to method. The result I am looking for is that you click the column and get the show page:

<div class="subcolumns">
  <div class="c25l">
        <div class="subcl">
        <%= image_tag album.photo.media.url(:thumb), :class => "image" rescue nil  %>
        </div>
    </div>
  <div class="c75r">
        <div class="subcr">
            <p><%= album.created_at %></p>
            <%= link_to h(album.title), album %>
            <p><%= album.created_at %></p>
            <p><%= album.photo_count %></p>
        </div>
  </div>
</div>

Arslan Ali · Accepted Answer · 2015-04-20 09:43:55Z

293

link_to takes a block of code ( >= Rails 2.2) which it will use as the body of the tag.

So, you do

<%= link_to(@album) do %>
  html-code-here
<% end %>

But I'm quite sure that to nest a div inside a a tag is not valid HTML.

EDIT: Added = character per Amin Ariana's comment below.

edited Apr 20, 2015 at 9:43

Arslan Ali

17.9k10 gold badges64 silver badges85 bronze badges

answered Jul 6, 2009 at 10:51

Thorbjørn Hermansen

3,5521 gold badge23 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

chucknelson Over a year ago

This comment is just a reference: <a><div></div></a> is valid in HTML5, but not in earlier HTML specs. See stackoverflow.com/questions/796087/make-a-div-into-a-link for a similar question.

daedelus_j Over a year ago

Rails 2.3.8 still getting "syntax error, unexpected ')'" using the above syntax.

Obromios Over a year ago

If you have a more complex path, you can just add in the parameters, missing the initial content, e.g. <%= link_to some_path, method: :post %>

Arslan Ali · Accepted Answer · 2015-04-20 09:23:42Z

15

Also, this may be an issue for some:

Make sure to write <%= if you are doing a simple link with code in it instead of <%.

e.g.

<%= link_to 'some_controller_name/some_get_request' do %>
  Hello World
<% end  %>

edited Apr 20, 2015 at 9:23

Arslan Ali

17.9k10 gold badges64 silver badges85 bronze badges

answered Dec 19, 2011 at 5:33

sybohy

1,8862 gold badges20 silver badges25 bronze badges

1 Comment

m33lky Over a year ago

I think this is required in Rails 3+

Omar Qureshi · Accepted Answer · 2009-07-06 20:43:46Z

9

For older Rails versions, you can use

<% content_tag(:a, :href => foo_path) do %>
  <span>Foo</span>
<% end %>

answered Jul 6, 2009 at 20:43

Omar Qureshi

9,1033 gold badges35 silver badges35 bronze badges

Comments

Barry Gallagher · Accepted Answer · 2009-07-06 10:44:56Z

7

You can use link_to with a block:

<% link_to(@album) do %>
    <!-- insert html etc here -->
<% end %>

answered Jul 6, 2009 at 10:44

Barry Gallagher

6,2464 gold badges29 silver badges30 bronze badges

1 Comment

Brandon Over a year ago

link_to requires '=' to show up (even with a block)

Rob Dawson · Accepted Answer · 2011-09-06 05:48:55Z

-4

A bit of a lag on this reply I know -- but I was directed here today, and didn't find a good answer. The following should work:

<% link_to raw(html here), @album %>

answered Sep 6, 2011 at 5:48

Rob Dawson

1,34711 silver badges21 bronze badges

4 Comments

Aurril Over a year ago

This shouldn't be used as all html entered inside the raw is prone to XSS.

GMA Over a year ago

Not necessarily, it might be the case that the HTML is being generated from somewhere within your own app which you know to be safe. Still, it's best to avoid this in 99% of situations. (Not to mention the above code has a mistake anyway, it should start with <%=, not <%.)

Joshua Dance Over a year ago

Not the best way. html here would have to be generated by your own app and ensured to be safe. There are other better ways in answers above.

jeffci Over a year ago

definitely worst answer on here. Do not do this!

Collectives™ on Stack Overflow

How do I wrap link_to around some html ruby code?

5 Answers 5

3 Comments

1 Comment

Comments

1 Comment

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

3 Comments

1 Comment

Comments

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related