CSS depends on result PHP if-statement

Question

I wrote a little script where an item should be bold whenever a certain value is set to 0. But I have the feeling I'm repeating myself... Is there a way to avoid this repeat?

$output .= '<td>';
if ('0' == $value['treated']) {
    $output .= '<b>';
}
$output .= $value['from'];
$output .= substr($value['message'], 20);
if ('0' == $value['treated']) {
     $output .= '</b>';
}
$output .= '</td>';

Maybe you should checkout DOMDocument.

jgroenen
– jgroenen

2012-06-07 10:29:09 +00:00
Commented Jun 7, 2012 at 10:29 — jgroenen
– jgroenen, Commented Jun 7, 2012 at 10:29

Gavin · Accepted Answer · 2012-06-07 10:18:20Z

5

You could set a class instead?

$output .= '<td' . ('0' == $value['treated'] ? ' class="bold"' : '') . '>';
$output .= $value['from'];
$output .= substr($value['message'], 20);
$output .= '</td>';

All you would then need to do is add

.bold { font-weight: bold; }

to your css file

answered Jun 7, 2012 at 10:18

Gavin

6,3695 gold badges32 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

deceze · Accepted Answer · 2012-06-07 10:19:50Z

1

$output = $value['from'] . substr($value['message'], 20);

if ('0' == $value['treated']) {
    $output = "<b>$output</b>";
}

$output = "<td>$output</td>";

answered Jun 7, 2012 at 10:19

deceze♦

525k89 gold badges807 silver badges954 bronze badges

4 Comments

Michiel Over a year ago

Won't I get issues when using $output in both cases? Won't it be overwritten?

deceze Over a year ago

Yes, it will be overwritten. But it's not an issue. IMO, consecutively wrapping your output in the necessary tags is a lot easier than cobbling together tags in a sequential way as you are doing.

Michiel Over a year ago

True that! And why should I use your method and not the class-method? Are there certain advantages in this method comparing to the other?

deceze Over a year ago

Classes will work fine as well. It depends on whether you want a <b> tag (probably better a <strong> tag nowadays), which is semantic, or a class, which is just style.

Daniel · Accepted Answer · 2012-06-07 10:21:05Z

0

I don't know if this is what you are looking for, but you could buffer the contents:

$output .= "<td>";
$buffer = $value['from'];
$buffer = substr($value['message'], 20);
$output .= ('0' == $value['treated'])
    ? "<b>" . $buffer . "</b>"
    : $buffer;

Edit: I see deceze was first :)

answered Jun 7, 2012 at 10:21

Daniel

3,8165 gold badges32 silver badges52 bronze badges

Comments

Miqdad Ali · Accepted Answer · 2012-06-07 10:23:04Z

0

This is a simple way you can acheive

$output .= '<td>';
        $bs = '';
        $be = '';
        if ('0' == $value['treated']) {
            $bs = '<b>';
            $be = '</b>';
        }
        $output .= $bs;
        $output .= $value['from'];
        $output .= substr($value['message'], 20);
        $output .= $be;
    $output .= '</td>';

or

$output .= '<td';
    if ('0' == $value['treated']) {
        $output .=' style="font-weight:bold;"';
    }
    $output .= '>';
    $output .= $value['from'];
    $output .= substr($value['message'], 20);
$output .= '</td>';

answered Jun 7, 2012 at 10:23

Miqdad Ali

6,1577 gold badges34 silver badges50 bronze badges

Comments

jgroenen · Accepted Answer · 2012-06-08 13:10:09Z

0

$dom = new DOMDocument;
$dom->loadHTML('<html/>');
$body = $dom->documentElement->appendChild($dom->createElement('body'));
for ( $i = 0; $i < 100; ++$i ) {
    $div = $body->appendChild($dom->createElement('div'));
    if ( rand() % 2 ) {
        $div->setAttribute('class', 'highlighted');
        $div->nodeValue = 'bold';
    } else {
        $div->nodeValue = 'normal';
    }
}
die($dom->saveHTML());

answered Jun 8, 2012 at 13:10

jgroenen

1,3361 gold badge8 silver badges13 bronze badges

Collectives™ on Stack Overflow

CSS depends on result PHP if-statement

5 Answers 5

Comments

4 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

4 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related