Bad XML Parsing Java

Question

I've developed a method to insert a new element in a XML File. I'm testing it reading the first element Usuario of the input file and appending it at the end.

Input:

<Usuarios>
        <Usuario>
                <id>identificador</id>
                <email>[email protected]</email>
                <rol>profesor</rol>
                <alta>01/01/2012</alta>
                <baja>30/08/2021</baja>
        </Usuario>
        <Usuario>
                <id>00000000H</id>
                <email>[email protected]</email>
                <rol>profesor</rol>
                <alta>01/01/2012</alta>
                <baja>30/08/2021</baja>
        </Usuario>
        <Usuario>
                <id>970104</id>
                <email>[email protected]</email>
                <rol>alumno</rol>
                <alta>01/01/2012</alta>
                <baja>30/08/2021</baja>
        </Usuario>
</Usuarios>

Output:

<Usuarios>
        <Usuario>
                <id>identificador</id>
                <email>[email protected]</email>
                <rol>profesor</rol>
                <alta>01/01/2012</alta>
                <baja>30/08/2021</baja>
        </Usuario>
        <Usuario>
                <id>00000000H</id>
                <email>[email protected]</email>
                <rol>profesor</rol>
                <alta>01/01/2012</alta>
                <baja>30/08/2021</baja>
        </Usuario>
        <Usuario>
                <id>970104</id>
                <email>[email protected]</email>
                <rol>alumno</rol>
                <alta>01/01/2012</alta>
                <baja>30/08/2021</baja>
        </Usuario>
<Usuario>
        <id>identificador</id>
        <email>[email protected]</email>
        <rol>profesor</rol>
        <alta>01/01/2012</alta>
        <baja>30/08/2021</baja>
    </Usuario>
</Usuarios>

What am I doing bad? There are two issues:

1.- The elements in the input are not properly indented y the output file. The transformer don't reindents all the registers? 2.- The new element is properly indented, but the new instance of not.

Ideas?

source:

public void almacenarUsuario(UsuarioNegocio usuario) throws Exception {
    DocumentBuilderFactory dbFactory = DocumentBuilderFactory.newInstance();
    DocumentBuilder dBuilder = dbFactory.newDocumentBuilder();
    Document doc = dBuilder.parse(new File(directorio + "personas.xml"));

    Element nUsuario = (Element) doc.getElementsByTagName("Usuarios").item(0);
    Node node = doc.createElement("Usuario");         
    nUsuario.appendChild(node);         

    Element nid = doc.createElement("id");         
    nid.appendChild(doc.createTextNode(usuario.getIdUsuario()));
    node.appendChild(nid);

    Element nemail = doc.createElement("email");         
    nemail.appendChild(doc.createTextNode(usuario.getEmail()));
    node.appendChild(nemail);

    Element nrol = doc.createElement("rol");         
    nrol.appendChild(doc.createTextNode(usuario.getRol()));
    node.appendChild(nrol);

    Element nalta = doc.createElement("alta");         
    nalta.appendChild(doc.createTextNode(usuario.getFecha_alta()));
    node.appendChild(nalta);

    Element nbaja = doc.createElement("baja");         
    nbaja.appendChild(doc.createTextNode(usuario.getFecha_baja()));
    node.appendChild(nbaja);    

    // Formatter //                                       
    TransformerFactory transformerFactory = TransformerFactory.newInstance();
    transformerFactory.setAttribute("indent-number", new Integer(25));
    Transformer transformer = transformerFactory.newTransformer();
    transformer.setOutputProperty(OutputKeys.METHOD, "xml");
    transformer.setOutputProperty(OutputKeys.ENCODING, "utf-8");   
    transformer.setOutputProperty(OutputKeys.OMIT_XML_DECLARATION, "yes");   
    transformer.setOutputProperty(OutputKeys.INDENT, "yes");   
    transformer.setOutputProperty("{http://xml.apache.org/xalan}indent-amount","4");        

    DOMSource source = new DOMSource(doc);
    StreamResult result = new StreamResult(new File("/opt/icxp1/Temporal/jose/personal/nuevo.xml"));
    transformer.transform(source, result);
}

Why do you care about indentation? That doesn't make the XML invalid in any way, does it? — Qnan
– Qnan, Commented Jul 6, 2012 at 11:13

sgowd · Accepted Answer · 2012-07-06 12:09:59Z

3

Before transforming,

transformer.setOutputProperty(OutputKeys.INDENT, "yes");

answered Jul 6, 2012 at 12:09

sgowd

2,26222 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

minyatur Over a year ago

It is there... code transformer.setOutputProperty(OutputKeys.METHOD, "xml"); transformer.setOutputProperty(OutputKeys.ENCODING, "utf-8"); transformer.setOutputProperty(OutputKeys.OMIT_XML_DECLARATION, "yes"); transformer.setOutputProperty(OutputKeys.INDENT, "yes"); transformer.setOutputProperty("{xml.apache.org/xalan}indent-amount","4"); DOMSource source = new DOMSource(doc); code

Qnan Over a year ago

why do you set the indent amount to 4, when it's 8 in the original document?

minyatur Over a year ago

There is no particular reason, yet the code does not work properly

Collectives™ on Stack Overflow

Bad XML Parsing Java

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related