C: variable has initializer but incomplete type

Question

Trying to get my head around the old C language. Currently on structs and getting this error:

"variable 'item1' has initializer but incomplete type"

Here's my code:

typedef struct
{
    int id;
    char name[20];
    float rate;
    int quantity;
} item;

void structsTest(void);

int main()
{
    structsTest();

    system("PAUSE");
    return 0;
}

void structsTest(void)
{
    struct item item1 = { 1, "Item 1", 345.99, 3 };
    struct item item2 = { 2, "Item 2", 35.99, 12 };
    struct item item3 = { 3, "Item 3", 5.99, 7 };

    float total = (item1.quantity * item1.rate) + (item2.quantity * item2.rate) + (item3.quantity * item3.rate);
    printf("%f", total);
}

I guessed perhaps the struct defintion was in the wrong location so I moved it to the top of the file and recompiled, but I am still getting the same error. Where's my mistake?

bluish · Accepted Answer · 2012-07-17 12:15:09Z

22

Get rid of struct before item, you've typedef'd it.

edited Jul 17, 2012 at 12:15

bluish

27.5k28 gold badges126 silver badges185 bronze badges

answered Jul 17, 2012 at 2:35

Keith Nicholas

44.4k15 gold badges101 silver badges168 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chris Lutz · Accepted Answer · 2012-07-17 02:36:07Z

10

typedef struct { ... } item creates an unnamed struct type, then typedefs it to the name item. So there is no struct item - just item and an unnamed struct type.

Either use struct item { ... }, or change all your struct item item1 = { ... }s to item item1 = { ... }. Which one you do depends on your preference.

answered Jul 17, 2012 at 2:36

Chris Lutz

75.9k16 gold badges132 silver badges184 bronze badges

Comments

Geoff Reedy · Accepted Answer · 2012-07-17 02:43:50Z

6

The problem is that

typedef struct { /* ... */ } item;

does not declare the type name struct item, only item. If you want to be able to use both names use

typedef struct item { /* ... */ } item;

answered Jul 17, 2012 at 2:43

Geoff Reedy

36.3k3 gold badges60 silver badges79 bronze badges

Collectives™ on Stack Overflow

C: variable has initializer but incomplete type

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related