How to index a string array

Question

I have a string array in C# 3.5:

string [] times = new[] {“08:00 am” , “10:00 am”, “120”} ;

I would like to create indexes to times: StartTime, EndTime , ElapsedTime so that when I code:

StartTime= “09:00 am” ; 
EndTime= “11:00 am” ;

then times[0] is set to “09:00 am” , etc.

I could create 3 methods:

private void StartTime(string time)
{    times[0] = time;  }
private void EndTime(string time)
{    times[1] = time;  }
private void ElapsedTime(string time)
{    times[2] = time;   }

and code

StartTime("09:00");

but is there a simpler way to do it?

Why are you using an array when you should really have this in a class itself with private members? — Daniel A. White
– Daniel A. White, Commented Jul 21, 2009 at 14:36

jjnguy · Accepted Answer · 2009-09-30 22:39:17Z

20

What you should really do is create a new class to do this. Make the two times properties.

And the time elapsed is a function of the start and end times.

class Time 
{
    public DateTime StartTime{ get; set; }
    public DateTime EndTime{ get; set; }

    public String[] ToStringArray() 
    {
        String[] ret = new String[3];
        ret[0] = StartTime.ToString();
        ret[1] = EndTime.ToString();
        ret[2] = ElapsedTime().ToString();
        return ret;
    }

    public TimeSpan ElapsedTime() 
    {
        return EndTime.subtract(StartTime);
    }
}

edited Sep 30, 2009 at 22:39

answered Jul 21, 2009 at 14:36

jjnguy

139k54 gold badges298 silver badges328 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Stan R. Over a year ago

+1 show him a public property that returns all 3 in a string array and then it would be the perfect solution :)

Fredrik Mörk Over a year ago

@Matt: I would say it was well earned (and it's 95 when I write this).

jjnguy Over a year ago

It is a good lesson in code design. Make your code model what you are trying to do.

Patrick McDonald Over a year ago

I added a return statement to ToStringArray(), I assume this is still necessary in C#3.0, but please remove if I am wrong

jjnguy Over a year ago

@Patrick I didn't want that method to actually work. But thanks for the fix! :P

|

Fredrik Mörk · Accepted Answer · 2009-07-21 14:38:38Z

3

I don't know it it is simpler, but I would suggest taking the hard index references out of your code and replace them with constants, to make easier to maintain if the order of elements in the array would change in the future:

private const int START_TIME = 0;
private const int END_TIME = 1;
private const int ELAPSED_TIME = 2;

Then you will also get more readable code:

times[END_TIME] = time;

Unless you want to be more object oriented, in which case you should follow jjnguy's advice.

answered Jul 21, 2009 at 14:38

Fredrik Mörk

159k31 gold badges296 silver badges349 bronze badges

Comments

Stan R. · Accepted Answer · 2009-07-21 14:40:02Z

2

To add to jjnguy's answer, you should really have a class that holds the 3 properties, and then if you need an array you could have a public property that just has a getter and returns the 3 different times in a string array.

answered Jul 21, 2009 at 14:40

Stan R.

16.1k5 gold badges52 silver badges59 bronze badges

1 Comment

jjnguy Over a year ago

I added that functionality to my example.

Corey Sunwold · Accepted Answer · 2009-07-21 14:36:17Z

0

Use a dictionary. See here.

answered Jul 21, 2009 at 14:36

Corey Sunwold

10.3k6 gold badges53 silver badges55 bronze badges

Comments

Rob Windsor · Accepted Answer · 2009-07-21 14:38:43Z

0

How about an extension method?

public static class Extensions
{
   public static void StartTime(this string[] array, string value)
   {
      array[0] = value;
   }
}

answered Jul 21, 2009 at 14:38

Rob Windsor

6,9142 gold badges24 silver badges27 bronze badges

Comments

AdaTheDev · Accepted Answer · 2009-07-21 14:39:08Z

0

You can do this using a dictionary.

e.g.

Dictionary<string, string> times = new Dictionary<string, string>();
times.Add("StartTime","09:00am");
times.Add("EndTime","11:00am");

answered Jul 21, 2009 at 14:39

AdaTheDev

148k28 gold badges215 silver badges204 bronze badges

Collectives™ on Stack Overflow

How to index a string array

6 Answers 6

7 Comments

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

7 Comments

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related