Python type comparision

Question

Ok, so I have a list of tuples containing a three values (code, value, unit)

when I'm to use this I need to check if a value is an str, a list or a matrix. (or check if list and then check if list again)

My question is simply should I do like this, or is there some better way?

for code, value, unit in tuples:
    if isinstance(value, str): 
        # Do for this item
    elif isinstance(value, collections.Iterable):
        # Do for each item
        for x in value:
             if isinstance(x, str):
                  # Do for this item
             elif isinstance(x, collections.Iterable):
                  # Do for each item
                  for x in value:
                      # ...
             else:
                  raise Exception
    else:
        raise Exception

The body of the outer for loop is rather confusing. Shouldn't there be x instead of value in the first line? And shouldn't the inner loop be something like for y in x? — Sven Marnach
– Sven Marnach, Commented Jul 23, 2012 at 12:28

Duncan · Accepted Answer · 2012-07-23 12:28:48Z

3

The best solution is to avoid mixing types like this, but if you're stuck with it then what you've written is fine except I'd only check for the str instance. If it isn't a string or an iterable then you'll get a more appropriate exception anyway so no need to do it yourself.

for (code,value,unit) in tuples:
    if isinstance(value,str): 
        #Do for this item
    else:
        #Do for each item
        for x in value:
             if isinstance(value,str):
                  #Do for this item
             else:
                  #Do for each item
                  for x in value:

answered Jul 23, 2012 at 12:28

Duncan

96.4k15 gold badges129 silver badges160 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Aaron Digulla · Accepted Answer · 2012-07-23 12:28:00Z

2

This works but every time you call isinstance, you should ask yourself "can I add a method to value instead?" That would change the code into:

for (code,value,unit) in tuples:
    value.doSomething(code, unit)

For this to work, you'll have to wrap types like str and lists in helper types that implement doSomething()

answered Jul 23, 2012 at 12:28

Aaron Digulla

330k111 gold badges626 silver badges840 bronze badges

1 Comment

Viktor Mellgren Over a year ago

I wont actually do anything on the value, but assign value(s) to an excelsheet. I believe it is easier for me to do like Duncan says.

Community · Accepted Answer · 2017-05-23 10:34:51Z

2

An alternative to your approach is to factor out this code into a more general generator function (assuming Python 2.x):

def flatten(x):
    if isinstance(x, basestring):
        yield x
    else:
        for y in x:
            for z in flatten(y):
                yield y

(This also incorporates the simplifications suggested and explained in Duncan's answer.)

Now, your code becomes very simple and readable:

for code, value, unit in tuples:
    for v in flatten(value):
        # whatever

Factoring the code out also helps to deal with this data structure at several places in the code.

edited May 23, 2017 at 10:34

CommunityBot

11 silver badge

answered Jul 23, 2012 at 12:33

Sven Marnach

608k123 gold badges968 silver badges865 bronze badges

Comments

user647772 · Accepted Answer · 2012-07-23 12:28:05Z

1

Just use the tuples and catch any exceptions. Don't look before you jump :)

answered Jul 23, 2012 at 12:28

user647772

1 Comment

Aesthete Over a year ago

I think you mean, Easier to Ask forgiveness than Permission :)

Aesthete · Accepted Answer · 2012-07-23 12:48:09Z

0

Recursion will help.

def processvalue(value):
  if isinstance(value, list): # string is type Iterable (thanks @sven)
    for x in value:
      processvalue(value)
  else:
    # Do your processing of string or matrices or whatever.


# Test each the value in each tuple.
for (code, value, unit) in tuples:
  processvalue(value)

This is a neater way of dealing with nested structures, and will also give you the ability to process abitrary depths.

edited Jul 23, 2012 at 12:48

answered Jul 23, 2012 at 12:36

Aesthete

18.9k6 gold badges38 silver badges46 bronze badges

2 Comments

Viktor Mellgren Over a year ago

In this case I know that 2dimensional arrays are the largest, and i have to index them, which might be harder using this approach

Aesthete Over a year ago

I don't understand what you mean by indexing them.

Collectives™ on Stack Overflow

Python type comparision

5 Answers 5

Comments

1 Comment

Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related