1

can someone tell me what's wrong with this code:

#include <stdio.h>
#include <stdlib.h>

#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER)
#define container_of(ptr, type, member) ({                                     \
                        const typeof( ((type *)0)->member ) *__mptr = (ptr);   \
                        (type *)( (char *)__mptr - offsetof(type,member) );})
typedef struct _elem {
        int     a;
        float   b;
        double  c;
} elem;

int main(int argc, char **argv)
{
        elem    *my_elem = (elem *)malloc(sizeof *elem);

        my_elem->a = 1;
        my_elem->b = 2;
        my_elem->c = 3;
        elem     *new_elem_a = container_of(&(my_elem->a), struct _elem, int);
        fprintf(stdout, "container_of(&(my_elem->a), struct _elem, int) = %p", new_elem_a);

        return 0;
}

When i compile i got this errors:

evariste@UnixServer:~$ gcc -Wall container_of_test.c -o container_of_test
container_of_test.c: In function ‘main’:
container_of_test.c:16:51: erreur: expected expression before ‘elem’
container_of_test.c:21:32: erreur: expected identifier before ‘int’
container_of_test.c:21:32: erreur: expected identifier before ‘int’

Thanks for your help.

1 Answer 1

2

There's 2 errors here

  1. That container_of macro expects the last argument to be the member name. So it should be

    elem *new_elem_a = container_of(&(my_elem->a), struct _elem, a);

  2. elem *my_elem = (elem *)malloc(sizeof *elem)

    has the wrong operand to sizeof, it should be

    elem *my_elem = (elem *)malloc(sizeof *my_elem)

Sign up to request clarification or add additional context in comments.

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.