UPDATE password in mySQLDatabase with PHP

Question

I am trying to update the password of the table 'nbk6_user'.

when the script is launched I get the error: "Fehler"

Am I doing the mysql_query right?

Can anybody help me please?

<?php
include 'conf.php';
$connection = mysql_connect("****", "****", "****");
mysql_select_db($datenbank);
session_start();

if(!isset($_SESSION["name"]))
{
    die("Für diese Seite musst du dich zuerst anmelden!");
}
$name = $_SESSION["name"];

$pw1 = $_POST["pw1"];
$pw2 = $_POST["pw2"];

$pw1 = trim($pw1);
$pw2 = trim($pw2);

if($pw1 == "")
{
die("Kein Passwort gesetzt.");
}

if($pw1 == $pw2)
{
    $query = mysql_query("UPDATE nbk6_user SET password='$pw1', WHERE name='$name'");
    if(!$query)
    {   
        echo "Fehler";
    }
}
else
{
    echo "Die Passwörter stimmen nicht überein";
}
?>

remove the comma before where

Gntem
– Gntem

2012-08-02 13:51:22 +00:00
Commented Aug 2, 2012 at 13:51 — Gntem
– Gntem, Commented Aug 2, 2012 at 13:51

Carlos Alberto Blanco Vivas · Accepted Answer · 2012-08-02 13:50:00Z

1

try see the error with mysql_error, but I think that u are putting "," after password='$pw1' I think so just try it

answered Aug 2, 2012 at 13:50

Carlos Alberto Blanco Vivas

1371 silver badge10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kasia Gogolek · Accepted Answer · 2012-08-02 13:50:57Z

0

You shouldn't have a coma after SET and it's best to avoid inserting the variables inside a string, when dealing with MySQL queries (or any strings really, it's bad practice).

Try:

$query = mysql_query("UPDATE nbk6_user SET password='".$pw1."' WHERE name='".$name."'");
if(!$query)
{   
    mysql_error();
    echo "Fehler";
}

if the changed query doesn't fix it mysql_error() will explain where the issue is.

answered Aug 2, 2012 at 13:50

Kasia Gogolek

3,4044 gold badges35 silver badges51 bronze badges

Comments

Marc B · Accepted Answer · 2012-08-02 14:01:55Z

0

You have a dangling comma:

... SET password='$pw1', WHERE ...
                       ^---

answered Aug 2, 2012 at 14:01

Marc B

362k44 gold badges433 silver badges508 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 12:30:16Z

0

Error in the query use this

$query = mysql_query("UPDATE nbk6_user SET password='".$pw1."' WHERE name='".$name."'");

Also read the first answer here, this will brief you why you should not use mysql_* and use mysqli and PDO , taking care of sql injections.

edited May 23, 2017 at 12:30

CommunityBot

11 silver badge

answered Aug 2, 2012 at 13:48

amitchhajer

13k6 gold badges43 silver badges54 bronze badges

4 Comments

benni Over a year ago

then I get this error Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in /home/.sites/26/site2378/web/nbk6/changepw.php on line 57 (line 57 is the mysql_query - line)

amitchhajer Over a year ago

I think you are missing the quotes in the end of query, check it once mysql_query("UPDATE nbk6_user SET password="'.$pw1.'" WHERE name="'.$name.'" ")

Marc B Over a year ago

-1. Changing string concatenation methods does NOTHING. $x = "a$b" is functionally identical to $x = 'a' . $b. All you've done is rearrange deck chairs on the titanic.

amitchhajer Over a year ago

you do need quotes around string type variables in sql, so to add them you need to concatenate multiple strings in php.

Tristan · Accepted Answer · 2015-11-23 20:56:36Z

0

At first :

session_start(); must be the first line in your code.

Then

 $query = mysql_query("UPDATE nbk6_user SET password='$pw1', WHERE name='$name'");
must be
$pw1=md5($pw1);
 $query = mysql_query("UPDATE nbk6_user SET password='$pw1' WHERE name='$name'");

edited Nov 23, 2015 at 20:56

Tristan

3,3218 gold badges25 silver badges27 bronze badges

answered Nov 23, 2015 at 20:28

ata

1

Collectives™ on Stack Overflow

UPDATE password in mySQLDatabase with PHP

5 Answers 5

Comments

Comments

Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related