C#: Using the String.Split method to split a list of string at each separate line?

Question

I am trying to split my list of strings at each separate lines using the String.Split method but the both the method below and a regex method did not work. Instead, they returned the following result {0} 0. System.String[] instead of the actual array of strings. Please help to find the error(s) in the code below:

    string m_settings_temp;
    string[] m_settings;
    public void ShowSettingsGui() {
       var dialog = new OpenFileDialog { Filter = "Data Sources (*.ini)|*.ini*|All Files|*.*" };
       if (dialog.ShowDialog() != DialogResult.OK) return;
       m_settings_temp = File.ReadAllText(dialog.FileName);
       m_settings = m_settings_temp.Split(new [] { '\r', '\n' });
       //This regex method failed as well:  
       //m_settings = Regex.Split(m_settings_temp,"\r\n|\r|\n");
    }

    //The method below is to evaluate the output
    protected override void SolveInstance(IGH_DataAccess DA)
                    {
                        if (m_settings == null)
                        {
                            AddRuntimeMessage(GH_RuntimeMessageLevel.Warning, "You must declare some valid settings");
                            return;
                        }
                        DA.SetData(0, m_settings);
                    }

Thanks in advance!

The methods return an array of strings - not a single string. — Oded
– Oded, Commented Aug 13, 2012 at 10:28

Jodrell · Accepted Answer · 2012-08-13 11:00:31Z

7

just use ReadAllLines like this

m_settings = File.ReadAllLines(dialog.FileName);

this will give you a string[] with an element for each line in the selected file. If, after running this code, m_settings has no elements, the file you selected was empty.

If I wanted to interrgoate the contents of m_settings in a console app I might do somthing like.

for (var i = 0; i < m_settings.Length; i ++)
{
    Console.WriteLine(m_settings[i]);
}

This would output the content of array, one element at a time. If I used the implementation of ToString for am array, like this,

Console.WriterLine(m_settings);

I would get a string representation of the array's type and the number of elements it contains.

I suspect in your case you want to do somthing like

protected override void SolveInstance(IGH_DataAccess DA)
{
     if (m_settings == null || m_settings.Length == 0)
     {
         AddRuntimeMessage(
              GH_RuntimeMessageLevel.Warning,
              "You must declare some valid settings");

         return;
     }

     for (var i = 0; i < m_settings.Length; i ++)
     {
         DA.SetData(i, m_settings[i]);
     }
}

edited Aug 13, 2012 at 11:00

answered Aug 13, 2012 at 10:28

Jodrell

35.9k6 gold badges94 silver badges131 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

pjvds Over a year ago

+1 That is better than splitting it yourself. It keeps the code clean.

Matthew Watson Over a year ago

In some cases it's better to use File.ReadLines() (msdn.microsoft.com/en-us/library/dd383503) which will let you enumerate over all the lines in a file WITHOUT storing them all in memory. This can be important for very large files.

Arthur Mamou-Mani Over a year ago

Thanks a lot but I am still getting the {0} 0. System.String[] as output instead of the actual string array.

Jodrell Over a year ago

@arthurmani, how are you evaluating the ouput? You don't show that in your sample.

Jodrell Over a year ago

Okay, I don't know enough about IGH_DataAccess to tell you exactly what is right. I suspect your orginal code is more correct. Possibly, when you access the settings you will need to do somthing like DA.GetData(0)[0] but I am just guessing. It all depends how array values are treated by your component framework.

|

Dennis Traub · Accepted Answer · 2012-08-13 10:28:32Z

1

m_settings = m_settings_temp
    .Split(new string[] { Environment.NewLine }, StringSplitOptions.None);

answered Aug 13, 2012 at 10:28

Dennis Traub

51.9k7 gold badges100 silver badges113 bronze badges

Comments

pjvds · Accepted Answer · 2012-08-13 10:31:12Z

1

string m_settings_temp;
string[] m_settings;
public void ShowSettingsGui()
{
    var dialog = new OpenFileDialog { Filter = "Data Sources (*.ini)|*.ini*|All Files|*.*" };
    if (dialog.ShowDialog() != DialogResult.OK) return;

    m_settings_temp = File.ReadAllText(dialog.FileName);
    m_settings = m_settings_temp.Split(new string[] { Environment.NewLine }, StringSplitOptions.None);
}

answered Aug 13, 2012 at 10:31

pjvds

9566 silver badges11 bronze badges

Collectives™ on Stack Overflow

C#: Using the String.Split method to split a list of string at each separate line?

3 Answers 3

9 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

9 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related