C++ do while loop with cin

Question

Below is my do while loop with cin There a bit of problem, when user enter Fullname then press enter. The pointer will go to next line. until user press enter again, then it prompt Email address, how do i make it prompt email address right after full name is entered on my code below

Terminal Look:

Full Name: John
Email Address: [email protected]

My test.cpp code:

emailAddress= "";
fullname = "";
counter = 0;

if(department_selection!="")
{

while(fullname=="")
{
if(counter>0)
{
//so it wont print twice
cout << "Full Name: ";
}

getline(cin,fullname);
cin.clear();
cin.ignore();
counter++;
}

counter = 0;

while(emailAddress=="")
{
if(counter>0)
{
//so it wont print twice
cout << "Email Address: ";
}

getline(cin,emailAddress);
cin.clear();
cin.ignore();
counter++;
}

}// if department selection not blank

Still same issue. i need to tab enter once then it prompt for email address.

Latest Update: Manage to fix it. I make changes to the code and it is this version:

do
{
  if(counter==0)
  {
     //so it wont print twice
     cout << "Full Name: ";
  }
  if(counter>1)
  {
     //so it wont print twice
     cout << "Full Name: ";
  }

  getline(cin,fullname);
  counter++;
} while (fullname=="");

counter = 0;

do
{
  if(counter==0)
  {
     //so it wont print twice
     cout << "Email Address: ";
  }
  if(counter>1)
    {
         cout << "Email Address: ";
    }

  getline(cin,emailAddress);
  counter++;
} while (emailAddress=="");

You should use a variable that is local to the scope of the do/while loops. I assume counter is declared outside of both while loops. — user195488
– user195488, Commented Aug 20, 2012 at 19:35

steveg89 · Accepted Answer · 2012-08-20 19:45:51Z

2

Instead of if(counter>0) use if(counter==0)

My working test app:

int counter = 0;
string fullname, emailAddress;
do
{
  if(counter==0)
  {
     //so it wont print twice
     cout << "Full Name: ";
  }

  getline(cin,fullname);
  counter++;
} while (fullname=="");

counter = 0;

do
{
  if(counter==0)
  {
     //so it wont print twice
     cout << "Email Address: ";
  }

  getline(cin,emailAddress);
  counter++;
} while (emailAddress=="");

edited Aug 20, 2012 at 19:45

answered Aug 20, 2012 at 19:38

steveg89

1,8272 gold badges16 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

perilbrain · Accepted Answer · 2012-08-20 19:46:55Z

1

Check for length and then @.

 do
    {
    ...
    }while(fullname.length()<2);

    do
    {
    ...
    }while(emailAddress.length()<3||emailAddress.find("@")==string::npos);

answered Aug 20, 2012 at 19:46

perilbrain

8,2092 gold badges29 silver badges35 bronze badges

3 Comments

steveg89 Over a year ago

What does input sanitation have to do with the prompt not appearing when it should?

perilbrain Over a year ago

@steveg89:- OP's code has no error.support.microsoft.com/… ..what should I then suggest :)

steveg89 Over a year ago

It does have an error. Look at my post and re-read his question. He was getting an extra getline before getting his prompt, because his condition for showing the prompt was wrong.

imulsion · Accepted Answer · 2012-08-20 19:36:07Z

0

Use the clear() and ignore() functions too to ignore words already stored in the input

answered Aug 20, 2012 at 19:36

imulsion

9,07620 gold badges59 silver badges85 bronze badges

6 Comments

steveg89 Over a year ago

That's more of a comment than an answer to his question.

imulsion Over a year ago

It should resolve the problem - what more does an answer need?

user1578897 Over a year ago

Hmm how should i change it to make it work with your clear and ignore.

imulsion Over a year ago

Once you've got the input stored, use like this:

imulsion Over a year ago

var.clear(); or var.ignore(); for the string variable storing the input

|

jrok · Accepted Answer · 2012-08-20 20:13:42Z

0

Define a function to avoid repeating code:

#include <iostream>
#include <string>
#include <limits>

using namespace std;

string get_input(const std::string& prompt)
{
    string temp;
    cout << prompt;
    while (!getline(cin, temp) || temp.empty()) {
        cin.clear();
        cin.ignore(numeric_limits<streamsize>::max(), '\n');
    }
    return temp;
}

int main()
{
    string fullname = get_input("Full Name: ");
    string email = get_input("Email Adress: ");
}

edited Aug 20, 2012 at 20:13

answered Aug 20, 2012 at 20:04

jrok

55.5k10 gold badges114 silver badges146 bronze badges

Collectives™ on Stack Overflow

C++ do while loop with cin

4 Answers 4

Comments

3 Comments

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

3 Comments

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related