AJAX/PHP emailer doesn't send email

Question

Here is my PHP mailer code:

if ($_POST) {
    $email=$_POST['email'];
    $subject=$_POST['subject'];
    $budget=$_POST['budget'];
    $text=$_POST['text'];
    $to="[email protected]";

    mail($to, "Piece of Cake = ".$subject, $text, "Budget:".$budget, "From:".$email );
}

And here is my AJAX email function:

$(function (){
    $('button#send_brief').click(function(){
        var email = $('#brief_email');
        var subject = $('#brief_type');
        var budget = $('#brief_budget');
        var text = $('#brief_comments');
        var emailerData = 'email' + email +'&subject' + subject + '&budget' + budget+ '&text' + text;

        if(text=='') {
            $('#brief_email').css({'background-color':'red'});
         }
         else {

        $.ajax({
            type: "POST",
            url:"emailer.php",
            data: emailerData,
            success: function(){
                $('.success').fadeIn(1000);
                setTimeout (function(){
                $('.brief').slideUp({
                    duration: 1000,
                    easing: 'easeInSine'});}
                            ,2000);
                setTimeout (function(){
                $('#brief').fadeIn();}
                            ,3000);
                setTimeout (function(){
                $('.success').fadeOut(1000);}
                            ,2000);
            }

        });

        return false;}
    });   

});

And here my form:

<form method="POST" action="" >
<fieldset>

            <label for="brief_email">Your email</label>
            <input type="text" id="brief_email" placeholder="your contact email here"/>
             etc ...
</fieldset>
</form>
<button id="send_brief">Send it</button>

First of all when I leave all fields empty, it still show me Success screen. And second of all I don't get emails, that it sends, even when I enter valid data.

I have reviewed the code many times and seems OK to me.

Please help me find where I am wrong.

It will always show success screen if the AJAX is ok. Your problem is in the php mailer code .. try to access it directly with already added variables and see the error .. point error here — Mihai Iorga
– Mihai Iorga, Commented Aug 31, 2012 at 10:35

Mihai Iorga · Accepted Answer · 2012-08-31 10:56:10Z

your problem is in the AJAX construct, you lack getting value with: val()

var email = $('#brief_email').val();
var subject = $('#brief_type').val();
var budget = $('#brief_budget').val();
var text = $('#brief_comments').val();

Without val() you will send an object to the PHP script and not a value.

And vars construct you lack =

var emailerData = 'email=' + email +'&subject=' + subject + '&budget=' + budget+ '&text=' + text;

Also your mail() construct is bad, you cannot send any other values than it requires check mail(). And you check for $_POST, $_POST is always true, you need to check at least one post value.

<?php

if (isset($_POST['email'])) {
    $email=$_POST['email'];
    $subject=$_POST['subject'];
    $budget=$_POST['budget'];
    $text=$_POST['text'];
    $to      = '[email protected]';

    $subject = "Piece of Cake = ".$_POST['subject'];
    $message = "New message from website

    Email: $email
    Budget: $budget
    Comments: $text";

    $headers = 'From: ' . $email . "\r\n" .
        'Reply-To: ' . $email . "\r\n" .
        'X-Mailer: PHP/' . phpversion();

    mail($to, $subject, $message, $headers);
}
?>

kushalbhaktajoshi · Accepted Answer · 2012-08-31 10:38:28Z

You need to check the email sent

if ($_POST) {
    $email=$_POST['email'];
    $subject=$_POST['subject'];
    $budget=$_POST['budget'];
    $text=$_POST['text'];
    $to="[email protected]";

    if(mail($to, "Piece of Cake = ".$subject, $text, "Budget:".$budget, "From:".$email )) echo '1';
    else echo '0';

}

Check the email sent response in ajax response

$(function (){
    $('button#send_brief').click(function(){
        var email = $('#brief_email');
        var subject = $('#brief_type');
        var budget = $('#brief_budget');
        var text = $('#brief_comments');
        var emailerData = 'email' + email +'&subject' + subject + '&budget' + budget+ '&text' + text;

        if(text=='') {
            $('#brief_email').css({'background-color':'red'});
         }
         else {

        $.ajax({
            type: "POST",
            url:"emailer.php",
            data: emailerData,
            success: function(result){
            if(result == 1){
    $('.success').fadeIn(1000);
                setTimeout (function(){
                $('.brief').slideUp({
                    duration: 1000,
                    easing: 'easeInSine'});}
                            ,2000);
                setTimeout (function(){
                $('#brief').fadeIn();}
                            ,3000);
                setTimeout (function(){
                $('.success').fadeOut(1000);}
                            ,2000);
}
            }

        });

        return false;}
    });   

});

Ja͢ck · Accepted Answer · 2012-08-31 10:40:50Z

1

Your email sending code has two problems:

mail($to, "Piece of Cake = ".$subject, $text, "Budget:".$budget, "From:".$email );

First problem is that you're not checking the return value:

if (false === mail( ... )) { echo "Yelp! Mail not sent"; }

Second problem is that your email headers should be combined into the fourth parameters:

mail($to, "Piece of Cake = ".$subject, $text, "Budget: $budget\r\nFrom: $email");

That's because the fifth parameter is meant for sendmail, it's not yet another field for email headers.

answered Aug 31, 2012 at 10:40

Ja͢ck

174k39 gold badges269 silver badges317 bronze badges

Collectives™ on Stack Overflow

AJAX/PHP emailer doesn't send email

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related