vbscript - if statement with returned value from a function?

Question

I have a function to show a MsgBox with a text selected from an array.

'# show the choosen message
Public Function ShowMessage(which)  
    ShowMessage = MsgBox(Message(which),vbyesno,"title")
end Function

The returnvalue from this function is the return value from the MsgBox itself. When I then try to ask for that value with an if-statement i get an error message saying that this is a wrong value assingment for that function.

if ShowMessage = vbYes then
    MsgBox "clicked ok"
    StartProgram("notepad.exe")
else
    MsgBox ("some error occurred")
end if

When i assing the value of ShowMessage to var1 and go for it with the if-statement I get no error messages.

'# show the choosen message
Public Function ShowMessage(which)  
    ShowMessage = MsgBox(Message(which),vbyesno,"title")
    var1 = ShowMessage
end Function

....

if var1 = vbYes then
    MsgBox "clicked ok"
    StartProgram("notepad.exe")
else
    MsgBox ("some error occurred")
end if

Why can't I get access the value direct in that statement, or am I doing something wrong here?

Jorge Fuentes González · Accepted Answer · 2012-09-06 10:59:23Z

1

That function needs a parameter, try this:

Public Function ShowMessage(which)  
    ShowMessage = MsgBox(which,vbyesno,"title")
end Function

if ShowMessage("Heya, I'm a message") = vbYes then
    MsgBox "clicked ok"
    StartProgram("notepad.exe")
else
    MsgBox ("some error occurred")
end if

answered Sep 6, 2012 at 10:59

Jorge Fuentes González

11.9k4 gold badges48 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Andrew Cooper · Accepted Answer · 2012-09-06 11:11:44Z

1

You can't just use the name of the function like it's a variable, because it isn't.

You have to invoke the function to get it's return value. The value can either be used directly, or stored in a variable for use later.

You can't do this:

ShowMessage("Polly want a cracker?")  ' The function is called here, the return value is lost
if ShowMessage = vbYes then           ' This does not get the return value
   ...
end if

You have to do either this:

if ShowMessage("Polly want a cracker?") = vbYes then    ' Return value used directly
    ...
end if

or this:

answer = ShowMessage("Polly want a cracker?")      ' Return value stored ...
if answer = vbYes then                             ' ... and then used here
    ....
end if

edited Sep 6, 2012 at 11:11

answered Sep 6, 2012 at 11:03

Andrew Cooper

32.7k5 gold badges86 silver badges124 bronze badges

Collectives™ on Stack Overflow

vbscript - if statement with returned value from a function?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related