PHP Table: I'm trying to create new row for every mysql table rows in my website

Question

Basically I've retrieved data from mysql on 1 line and made it look like a table with borders and stuff but I'd want it to repeat for every row on the mysql table. Here's the following code I've used so far:

while($info = mysql_fetch_array( $data )) 
 { 
 echo "<table width='1000' cellpadding='10' cellspacing='5' border='1'>"; 

 echo "<tr>


    <td><center><b>".$info['id']."</td></center></b>"."<td><center><b>".$info['username']."</td></center></b>"."<td><center><b>".$info['kills']."</td></center></b>"."<td><center><b>".$info['deaths']."</td></center></b>"."<td><center><b>".$info['ratio']."</td></center></b></tr>"; 

 echo "</table>"; 
 }

UPDATE:

 echo "<table width='1000' cellpadding='10' cellspacing='5' border='1'>"; 
 while($info = mysql_fetch_array( $data )) 
 { 
 echo "<tr> 
    <td><center><b>".$info['id']."</td></center></b>"."<td><center><b>".$info['username']."</td></center></b>"."<td><center><b>".$info['kills']."</td></center></b>"."<td><center><b>".$info['deaths']."</td></center></b>"."<td><center><b>".$info['ratio']."</td></center></b></tr>"; 

 } 
 echo "</table>";

Move the opening and closing <table> outside the while loop. — Michael Berkowski
– Michael Berkowski, Commented Sep 8, 2012 at 0:45
That should create a new table for each row in your mysql result set. Normally you would create a tr for every result, but either what you should see every row returned from your query with the code you posted. Are you sure theres more than one row being returned? — prodigitalson
– prodigitalson, Commented Sep 8, 2012 at 0:46
There are 2 rows on my query but it only returns the 2nd one. — Mirwais Maarij
– Mirwais Maarij, Commented Sep 8, 2012 at 0:57

Fluffeh · Accepted Answer · 2012-09-08 01:06:49Z

5

You want the table tage outside the loop that fetches the rows of data:

echo "<table width='1000' cellpadding='10' cellspacing='5' border='1'>"; 
while($info = mysql_fetch_array( $data )) 
{ 
    echo "<tr>
    <td><center><b>".$info['id']."</td></center></b>"."<td><center><b>".$info['username']."</td></center></b>"."<td><center><b>".$info['kills']."</td></center></b>"."<td><center><b>".$info['deaths']."</td></center></b>"."<td><center><b>".$info['ratio']."</td></center></b></tr>"; 
} 
echo "</table>";

As you are new to PHP I should probably expand this out a little more:

Your code will now echo out the table opening tag:

<table width='1000' cellpadding='10' cellspacing='5' border='1'>

Then go into the while loop and echo out all the rows that it finds:

<tr><td><center><b>Something1></b></td></tr> // shortened for example.
<tr><td><center><b>Something2></b></td></tr>
<tr><td><center><b>Something3></b></td></tr>
<tr><td><center><b>Something4></b></td></tr>

Then when it exists the loop, it will output the closing tag for the table:

</table>

What you were previously doing was outputting a table for each and every row of data. For future reference, it is a good idea to look into your source code to get an understanding of what is happening.

Edit: When I was going through your code comment, I formatted it out neater to see what was going on, you might want to make your code easier to read by having the following format:

echo "<table width='1000' cellpadding='10' cellspacing='5' border='1'>"; 
while($info = mysql_fetch_array( $data )) 
{ 
    echo "<tr> 
        <td><center><b>".$info['id']."</b></center></td>
        <td><center><b>".$info['user‌name']."</b></center></td>
        <td><center><b>".$info['kills']."</b></center></td>
        <td><center><b>".$info['deaths']."</b></center></td>
        <td><center><b>".$info['‌ratio']."</b></center></td>
        </tr>"; 
} 
echo "</table>";

edited Sep 8, 2012 at 1:06

answered Sep 8, 2012 at 0:45

Fluffeh

33.6k16 gold badges69 silver badges80 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Mirwais Maarij Over a year ago

I'm doing it all through the source code. But when I did what you mentioned, it still doesn't work. There are 2 rows in mysql db to be more exact, thought it only fetches the 2nd row...

Mirwais Maarij Over a year ago

This is what I've done: Please check question again, i've put updated code

Fluffeh Over a year ago

@MirwaisMaarij Good-O. I made an edit that you might want to take a peep at - will make your code easier to read and understand. Also, you should be closing tags in the same order that you open them - ie don't close a <td> tag before you close the </b> tag :)

FirmView Over a year ago

</center> what it does here? <tr align='center'> or <td align='center'> would do

Josh · Accepted Answer · 2012-09-08 00:45:31Z

1

Just move your table tags out of the loop.

echo '<table>';

foreach( $row )
{
  echo '<tr>....</tr>';
}

echo '</table>';

answered Sep 8, 2012 at 0:45

Josh

12.6k12 gold badges77 silver badges118 bronze badges

Collectives™ on Stack Overflow

PHP Table: I'm trying to create new row for every mysql table rows in my website

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related