How to simplify the conditional statement

Question

I am trying to simplify the following conditional statement. Are there better way to do this? Thanks.

 if ($element.is('#resize')) {
     css.left =+ 20;
     css.top =+ 3;

     if ($('#holder .Main').length < 5 ) {
         img.css('display', 'none');
     }

     img.insertBefore($element);
     img.css(css);

 } else if($element.is('#bt_id3')) {
     css.left =+ 20;
     css.top =+ 3;

     if ($('#id .Main').length < 5 ) {
         img.css('display', 'none');
     }

     img.insertBefore($element);
     img.css(css);
 }

You may want to post this over on codereview.stackexchange.com — j08691
– j08691, Commented Sep 10, 2012 at 19:30
It would also help if you detailed what you were trying to do/accomplish versus just posting the code. — Chase
– Chase, Commented Sep 10, 2012 at 19:31

Ethan Brown · Accepted Answer · 2012-09-10 19:36:48Z

2

The only thing different between the if and the else clauses is the selector in the internal if. You could isolate that this way:

var eltId = false;
if ($element.is('#resize')) eltId = '#holder';
if ($element.is('#bt_id3')) eltId = '#id';
if( eltId !== false ) {
    css.left=+20;
    css.top=+3;
    if($(eltId + ' .Main').length<5){img.css('display', 'none');}
    img.insertBefore($element);
    img.css(css);
}

That makes it a little DRYer.

answered Sep 10, 2012 at 19:36

Ethan Brown

27.4k5 gold badges84 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

tucuxi Over a year ago

essentially voting for my answer, as both are the same (except for eltId vs actually saving the reference, and spacing :-).

tucuxi · Accepted Answer · 2012-09-10 19:41:24Z

1

This does not change any workings, but it is still not too pretty. Lots of magic numbers and lack of comments and context make for weird code...

var e = false;
if ($element.is('#resize')) e = $('#holder .Main');
else if ($element.is('#bt_id3')) e = $('#id .Main');

if (e) {
      css.left=+20;
      css.top=+3;
      if (e.length<5) {
          img.css('display', 'none');
      }
      img.insertBefore($element);
      img.css(css);
}

edited Sep 10, 2012 at 19:41

answered Sep 10, 2012 at 19:36

tucuxi

18k2 gold badges48 silver badges80 bronze badges

Comments

Roko C. Buljan · Accepted Answer · 2012-09-10 21:48:29Z

1

if($element.is('#resize') || $element.is('#bt_id3')){
    var elem = $element.is('#resize') ? $('#holder .Main') : $('#id .Main');
    css.left=+20;
    css.top=+3;
    if(elem.length<5){img.hide();} // USE HERE THE 'elem' VARIABLE and '.hide()'
    img.insertBefore($element);
    img.css(css);
}

edited Sep 10, 2012 at 21:48

answered Sep 10, 2012 at 19:35

Roko C. Buljan

209k41 gold badges335 silver badges346 bronze badges

2 Comments

tucuxi Over a year ago

css top and left only get applied if the element is one or the other - but element may not be of either type!

Ethan Brown Over a year ago

One problem, Roko -- this code will execute if element isn't #resize or #id, which is not equivalent to the original code. Otherwise it's very pretty.

TrL · Accepted Answer · 2012-11-09 00:30:49Z

0

Here

$element.is("#resize") ? (css.left = 20, css.top = 3, 5 > $("#holder .Main")
.length && img.css("display", "none"), img.insertBefore($element), img.css(css)) : $element.is("#bt_id3") && (css.left = 20, css.top = 3, 5 > $("#id .Main")
.length && img.css("display", "none"), img.insertBefore($element), img.css(css))

answered Nov 9, 2012 at 0:30

TrL

302 bronze badges

Comments

pete · Accepted Answer · 2012-09-10 19:37:33Z

-1

A quick re-factor yields:

css.left = +20;
css.top = +3;

if ($element.is('#resize')) {
    if ($('#holder .Main').length < 5) {
        img.css('display', 'none');
    }
} else if ($element.is('#bt_id3')) {
    if ($('#id .Main').length < 5) {
        img.css('display', 'none');
    }
}

img.insertBefore($element);
img.css(css);

answered Sep 10, 2012 at 19:37

pete

25.2k4 gold badges40 silver badges52 bronze badges

1 Comment

Ethan Brown Over a year ago

Same problem as Roko's answer.

Collectives™ on Stack Overflow

How to simplify the conditional statement

5 Answers 5

1 Comment

Comments

2 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related