Javascript replace?

Question

<script>
var text = "a's ..a's ...\"... ";
text = convert(text);
function convert( text )
{
    var n = text.replace(/\'/g, "&#039;");
    n = text.replace(/\"/g,"&quot;");
    return n;

}
console.log(text);
document.write(text);

</script>

The problem is that when it replace the second time it take doesnt "remember" what it replaced the first time, so only the last replace is returned.

João Silva · Accepted Answer · 2012-09-11 14:33:31Z

4

That's because you are replacing the original text string in the second replace, instead of n, which is the value of the replaced text:

function convert( text )
{
    var n = text.replace(/\'/g, "&#039;");
    n = n.replace(/\"/g,"&quot;");
    return n;
}

replace does not modify your original string. Instead, it returns a new modified string . You can also do both replaces in a single statement:

return text.replace(/\'/g, "&#039;").replace(/\"/g,"&quot;");

answered Sep 11, 2012 at 14:33

João Silva

91.8k29 gold badges156 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Waleed Khan · Accepted Answer · 2012-09-11 14:33:24Z

1

function convert( text )
{
    var n = text.replace(/\'/g, "&#039;");
    // Wrong: n = text.replace(/\"/g,"&quot;");
    // This modifies the previously edited variable.
    n = n.replace(/\"/g,"&quot;");
    return n;

}

answered Sep 11, 2012 at 14:33

Waleed Khan

11.5k7 gold badges41 silver badges70 bronze badges

Collectives™ on Stack Overflow

Javascript replace?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related