PHP Insert into mysql

Question

So i have php code to insert form data in a table. Here's the code:

$link = @mysql_connect("***", "***", "****");
if (!$link) {
 echo "save_failed";
 return; 
}
mysql_select_db("***", $link);

$sql="INSERT INTO Conference (`First Name`, `Last Name`)
VALUES ('$_POST[fname]', '$_POST[lname]')";

mysql_close($link);

The *** are replaced with the actual values in the real code, obviously. But is there anything wrong with the above code? I tried to run it, it didn't have any errors with connection but it also didn't insert anything. Here's is what my mysql table looks like:

Also, I need the table to have an auto incremented number so that each entry is unique with it's own index value. Any ideas on either problem? Thanks

What does your generated SQL look like? If you echo out $sql, does it work when you run it in the database? — andrewsi
– andrewsi, Commented Sep 17, 2012 at 16:16
Please stop writing new code with the ancient mysql_* functions. They are no longer maintained and community has begun the deprecation process. Instead you should learn about prepared statements and use either PDO or MySQLi. If you care to learn, here is a quite good PDO-related tutorial. — user1233508
– user1233508, Commented Sep 17, 2012 at 16:21
This example has a severe SQL injection bug that should be patched immediately. You should not ever insert $_POST or $_GET data directly into your query. — tadman
– tadman, Commented Sep 17, 2012 at 16:25
@DCoder is right - if you don't use PDO, you will get pwned. — Tim G
– Tim G, Commented Sep 17, 2012 at 16:27

Havelock · Accepted Answer · 2012-09-17 16:17:20Z

6

You haven't executed the query, which should be done as it follows:

mysql_query($sql, $link);

Also, please consider using mysqli or even better PDO as the mysql package is deprecated (see the red box), i.e. mysql_query().

answered Sep 17, 2012 at 16:17

Havelock

7,0044 gold badges37 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Richard Over a year ago

wow i feel really stupid. Okay that worked perfectly, thank you. One more thing, is there any way to get that auto-incremented id number?

Havelock Over a year ago

From what I see on your screenshot, you don't have an id column in your table. Also it would be a good practice to replace space with an underscore.

Richard Over a year ago

Yah I tried putting an ID column but there is no setting to make it auto increment.

Havelock Over a year ago

Yes, there is. Have a good look in all the options to a field ;-)

Collectives™ on Stack Overflow

PHP Insert into mysql

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related