C# Datagridview last index out of bound

Question

hi guys im new here =)

i would need your help in a minimal troubble case, to save time for me =)

The problem is about that, i want to have datagridview Cells Values and save the values to an array.

Up to now it works fine, but it just reads the first row cell and after that process it just tells that the index is out of bound, but i dont understand why.

foreach (DataGridViewRow row in dataGridView1.Rows)     //wo soll er sich aufhalten -> zeilen
                {

                    **if (row.Cells[i].Value == null)**
                    {
                        MessageBox.Show("This row is empty");
                        break;
                    }
                        if (row.Cells[i].Value != null)
                        {
                            UnsortArray[i] = row.Cells[i].Value.ToString();
                            MessageBox.Show(UnsortArray[i]);
                            ++i;
                        }

                }

What is "i". You are using a foreach loop to loop through all the rows.You need to loop through columns as well. — Abhi.Net
– Abhi.Net, Commented Sep 24, 2012 at 6:32
Because it tries to read cell[length] on the next row, which is out of bounds. Use two variables for index, one which you reset to 0 on every row. — Thomas
– Thomas, Commented Sep 24, 2012 at 6:33
you want to store only one cell value in Array or all cell value ? In your code you mixup index 'i'. 'i' used as cell index as well as UnsortArray index. — Jignesh Thakker
– Jignesh Thakker, Commented Sep 24, 2012 at 6:44

Abhi.Net · Accepted Answer · 2012-09-25 00:55:31Z

2

    foreach (DataGridViewRow row in dataGridView1.Rows)   
                    {
                      for (int i=0; i<= dataGridView1.Columns.Count; i++)
{
                        **if (row.Cells[i].Value == null)**
                        {
                            MessageBox.Show("This row is empty");

                        }
                            if (row.Cells[i].Value != null)
                            {
                                UnsortArray[i] = row.Cells[i].Value.ToString();
                                MessageBox.Show(UnsortArray[i]);

                            }

    }



                    }

also, I don't understand why would you want to do messageBox.show inside a loop. It should be out side the loop.

edited Sep 25, 2012 at 0:55

answered Sep 24, 2012 at 6:36

Abhi.Net

7824 gold badges12 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jignesh Thakker Over a year ago

Why you increase i value in if (row.Cells[i].Value != null) block? for loop already increasing i value.

Anant Dabhi · Accepted Answer · 2012-09-24 06:37:17Z

2

foreach (DataGridViewRow row in dataGridView1.Rows)     //wo soll er sich aufhalten -> zeilen
                {

                    if (row.Cells[i].Value == null)
                        MessageBox.Show("This row is empty")
                    else
                        {
                            UnsortArray[i] = row.Cells[i].Value.ToString();
                            MessageBox.Show(UnsortArray[i]);
                   //    ++i;  dont need to increment if you want to read only specific column
                        }
                }

answered Sep 24, 2012 at 6:37

Anant Dabhi

11.2k3 gold badges33 silver badges51 bronze badges

2 Comments

Niko Over a year ago

Thank you very much, you solved my problem in the fastes possible way =) I tried to vote up, but its not possible yet! Do it afterwards!

Freelancer Over a year ago

@Niko: I will do it on behalf of you now

Freelancer · Accepted Answer · 2012-09-24 06:43:00Z

1

Try something like following code>>

for(int i=0;i<dataGridView1.Rows.Count;i++)
                {

                    if (dataGridView1.Rows[i].cells[i].Value==null)**
                    {
                        MessageBox.Show("This row is empty");
                        break;
                    }

                    else
                        {
                          UnsortArray[i] = dataGridView1.Rows[i].cells[i].Value.ToString();
                            MessageBox.Show(UnsortArray[i]);

                        }





                }

answered Sep 24, 2012 at 6:43

Freelancer

9,1027 gold badges46 silver badges81 bronze badges

Comments

Jignesh Thakker · Accepted Answer · 2012-09-24 07:59:51Z

1

Use different Index variable for UnSortArray (let say j). i is a index of cell which value you want to store in UnSortArray

CODE

            foreach (DataGridViewRow row in dataGridView1.Rows)     
            {

                if (row.Cells[i].Value == null)
                {
                    MessageBox.Show("This row is empty")
                }
                else
                    {
                        UnsortArray[j] = row.Cells[i].Value.ToString();
                        MessageBox.Show(UnsortArray[j]);
                        ++j;
                    }
            }

edited Sep 24, 2012 at 7:59

answered Sep 24, 2012 at 6:55

Jignesh Thakker

3,7082 gold badges31 silver badges35 bronze badges

Collectives™ on Stack Overflow

C# Datagridview last index out of bound

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related