Handling exceptions in global.asax ASP.NET MVC

Question

I have code which is catching all exceptions in Global.asax

 protected void Application_Error(object sender, EventArgs e) 
        {
            System.Web.HttpContext context = HttpContext.Current;
            System.Exception exc = context.Server.GetLastError();
            var ip = context.Request.ServerVariables["REMOTE_ADDR"];
            var url = context.Request.Url.ToString();
            var msg = exc.Message.ToString();
            var stack = exc.StackTrace.ToString();
        }

How I can get controller name where this error happened

How I can get request client IP?

And can I filter exceptions? I dont need 404, 504.... erors

thanks

I dont need 404, 504.... erors ehh? That's how HTTP works. And what do you mean with can I filter exceptions? — jgauffin
– jgauffin, Commented Sep 26, 2012 at 6:52
This post will definitely help you prideparrot.com/blog/archive/2012/5/… — VJAI
– VJAI, Commented Sep 26, 2012 at 12:39

Andrei · Accepted Answer · 2012-09-26 07:27:53Z

6

Global.asax has not notion of controllers and actions, so I believe there is no an API for retrieving controller and action names. However you might give a try for resolving request URL:

HttpContextBase currentContext = new HttpContextWrapper(HttpContext.Current);
UrlHelper urlHelper = new UrlHelper(HttpContext.Current.Request.RequestContext);
RouteData routeData = urlHelper.RouteCollection.GetRouteData(currentContext);
string action = routeData.Values["action"] as string;
string controller = routeData.Values["controller"] as string;

To get the user IP you can use UserHostAddress property:

string userIP = HttpContext.Current.Request.UserHostAddress;

To filter out HTTP exceptions that you are not going to handle you can use something like:

HttpException httpException = exception as HttpException;
if (httpException != null)
{
    switch (httpException.GetHttpCode())
    {
        case 404:
        case 504:
            return;
    }
}

One last remark about exception handling - it is not a best practice to do it at global level when there is a way to perform it more locally. For instance in ASP.NET MVC base Controller class has a method:

protected virtual void OnException(ExceptionContext filterContext)

which, when overridden, will give you full control on the occurred exception. You can have all the info that is available for you in Global.asax plus ASP.NET MVC specific features like a reference to controller, view context, route data etc.

edited Sep 26, 2012 at 7:27

answered Sep 26, 2012 at 7:15

Andrei

56.8k10 gold badges92 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Irakli Lekishvili Over a year ago

Andrei thank you for replay your code works perfectly. Can you provide some good tutorial about base controller class?

Andrei Over a year ago

@Acid, sure. For basic examples check out this blog post and this article.

Carter Medlin Over a year ago

You can skip the using UrlHelper usage (And skip the MVC reference) with...'RouteData routeData = System.Web.Routing.RouteTable.Routes.GetRouteData(currentContext);'

Rajpurohit · Accepted Answer · 2012-09-26 06:51:05Z

3

i used like this it's below

you can get user ip like this

var userip = context.Request.UserAgent;

and you can get your url where this error happened like this

var ururl = System.Web.HttpContext.Current.Request.Url;

i think this will help you...

answered Sep 26, 2012 at 6:51

Rajpurohit

2,0012 gold badges18 silver badges19 bronze badges

Comments

dove · Accepted Answer · 2012-09-26 07:42:25Z

0

I'd take a different tack and put use an attribute on your controllers (or base controller if you have one)

 public class HandleErrorAttributeCustom : HandleErrorAttribute
    {
       public override void OnException(ExceptionContext context)
        {
            //you can get controller by using
            context.Controller.GetType()

            //however, I'd recommend pluggin in Elmah here instead 
            //as it gives this easily and also can has filtering
            //options that you want

        }
}

answered Sep 26, 2012 at 7:42

dove

20.8k14 gold badges88 silver badges109 bronze badges

Collectives™ on Stack Overflow

Handling exceptions in global.asax ASP.NET MVC

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related