How to insert this array into a MYSQL database and why mine won't work?

Question

I am trying to insert this array into my database, using an implode statement. But i am struggling to find where I am going wrong: I basically am looking to convert the two functions below to return strings:

 function Titles($link) {
$str = file_get_contents($link);    
if( strlen( $str )>0 ) {    
    preg_match_all( "/\<title\>(.*)\<\/title\>/", $str, $titles );
    if (count($titles) > 1) {
        return $titles[1];   
    }
}

return '';
}

  function getMetas($link) {
$str1 = file_get_contents($link);    

if (strlen($str1)>0) {
    preg_match_all( '/<meta.*?name=("|\')description("|\').*?content=("|\')(.*?)("|\')/i', $str1, $description);
    if (count($description) > 1) {
        return $description[4];   
    }

}


 }


  $data = array();
  foreach ($links as $link) {
$output = array(
    "title"       => Titles($link), 
  "link"        => $link,
  "description" => getMetas($link),
  "keywords" => getKeywords($link) 
   );
   if (empty($output["description"])) 
   {$output["description"] = getWord($link);
  }
   $data[] = $output;
  }
  print_r($data);  

  mysql_query("INSERT INTO scan (title, url, description, keywords) VALUES ('".implode("'),('",$data)."')");

  if (!mysql_query()) {
echo "woops";
    }

   mysql_close($connect);

try implode("','",$data). You dont need to put individual values in brackets. — Umair Khan
– Umair Khan, Commented Sep 26, 2012 at 17:12

jeroen · Accepted Answer · 2012-09-26 17:26:11Z

1

The problem is that $data is a multi-dimensional array, so after you implode, you still have arrays instead of strings in your query.

You can solve that by using implode earlier on $output as well:

$data[] = implode(',', $output);

Apart from that you should use mysql_real_escape_string on your original variables but as the mysql_* functions are being deprecated, you really should switch to prepared statements in mysqli or PDO.

Edit: Actually you need to modify both implodes:

 $data[] = '"' . implode('","', $output) . '"';
 ...
 mysql_query( "INSERT INTO scan (title, url, description, keywords)
    VALUES (" . implode('),(',$data) . ")" );

edited Sep 26, 2012 at 17:26

answered Sep 26, 2012 at 17:12

jeroen

91.8k22 gold badges117 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Noah Smith Over a year ago

and how can I delete the 'Array' parts in my multidimensional array

Noah Smith Over a year ago

it doesn't have my title or description from my array

Noah Smith Over a year ago

it still won't work, it keeps returning the word 'Array' instead of title or description

jeroen Over a year ago

@Norman Berry That means your Titles and getMetas functions return arrays. You would need to fix that first.

Noah Smith Over a year ago

is there a way to convert those into strings if i show you both arrays?

|

Soumya Mohanan · Accepted Answer · 2012-09-26 17:48:48Z

0

Try this

$fields =   array_keys($data);
    $values =   array_values($data);

    $formatedValues =   array();
    foreach($values as $val)
    {   $val    =   "'".addslashes($val)."'";
        $formatedValues[]   =   $val;
    }
      $table="scan";

$sql    =   "INSERT INTO ".$table." (";
    $sql    .=  implode(", ",$fields).") ";
    $sql    .=  "VALUES( ";
    $sql    .=  implode(", ",$formatedValues);
    $sql    .=  ")";
    mysql_query($sql) or die(mysql_error());

edited Sep 26, 2012 at 17:48

answered Sep 26, 2012 at 17:43

Soumya Mohanan

3164 silver badges15 bronze badges

5 Comments

Noah Smith Over a year ago

is there a way to implode the two returned arrays from the functions above into a string to use in my INSERT

Noah Smith Over a year ago

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '0) VALUES( 'Array')' at line 1

Soumya Mohanan Over a year ago

@Norman Berry print_r(links) to check whether you get proper results

Noah Smith Over a year ago

will i have to implode the two function arrays or shall i just follow your code?

Soumya Mohanan Over a year ago

@Norman Berry the problem is with inserting array of values why don't you try to execute the insertion in foreach link itself,on behalf of assigning to array insert it to table.

Collectives™ on Stack Overflow

How to insert this array into a MYSQL database and why mine won't work?

2 Answers 2

9 Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related