Backbone.js: Uncaught TypeError: Object #<Object> has no method 'get'

Question

Hi I have a Collection which uses fetch() to do the initial fetch from the API. On a user's interaction, a second fetch is triggered, but instead of using the original fetch(), I used a fetchNew() that I defined myself:

Collection

ListingCollection = Backbone.Collection.extend({
    model: Listing,
    url: '/api/search_by_bounds',

    fetchNew: function(options) {
        options = options || {};
        var collection = this,
            success = options.success;
        options.success = function(resp, status, xhr) {
            _(collection.parse(resp, xhr)).each(function(item) {
                // added this conditional block
                if (!collection.get(item.id)) {
                    // Update collection
                    collection.add(item, {silent:true});
                    // Render View
                    new ListingMarkerView({ model:item }).render();
                }
            });
            if (!options.silent) {
                collection.trigger('reset', collection, options);
            }
            if (success) success(collection, resp);
        };
        return (this.sync || Backbone.sync).call(this, 'read', this, options);
    }
});

This will add only the new Models to the collection, and render only the Views of these new Models. (if all the Views are removed and re-rendered, it will cause a flicker)

View

ListingMarkerView = Backbone.View.extend({

    render: function() {
        var marker = L.marker([this.model.get('lat'), this.model.get('lng')]);
        markers.addLayer(marker);
    },

    close: function() {
        this.unbind;
    }

});

Error

However I am getting an error:

Uncaught TypeError: Object #<Object> has no method 'get'

which corresponds to this line in ListingMarkerView

var marker = L.marker([this.model.get('lat'), this.model.get('lng')]);

Debug

If I were to place a console.log(item) before the line that renders ListingMarkerView

console.log(item)
new ListingMarkerView({ model:item }).render();

I do see a valid item:

Object
    id: "2599084"
    lat: "42.276852"
    lng: "-71.165421"
    price: "2850"
    __proto__: Object

So...

Question

What seems to be the problem? How can this be solved? Thank you!

I'd rather go with usual .reset, why do you want to do that? Can you post a link to the working site so I can inspect? — Michał Miszczyszyn
– Michał Miszczyszyn, Commented Sep 29, 2012 at 18:39
Will .reset remove the items that were in the initial fetch() but not in the subsequent call? I wish to just append new models to the collection without removing the old ones. — Nyxynyx
– Nyxynyx, Commented Sep 29, 2012 at 18:42
If you want to add new ones without removing old ones, use fetch({add:true}). However you should still understand the answer I gave to your question, since it will definitely come up elsewhere. — blockhead
– blockhead, Commented Sep 29, 2012 at 18:46
Yes fetch{add:true}) has the effect that I want, thanks! However, I still cant render the View after using _.bindAll — Nyxynyx
– Nyxynyx, Commented Sep 29, 2012 at 18:50
Again: Can you post a link to the working site so I can inspect? — Michał Miszczyszyn
– Michał Miszczyszyn, Commented Sep 29, 2012 at 18:54

blockhead · Accepted Answer · 2012-09-29 18:38:37Z

6

The problem is render does not have this defined correctly. Add a initialize method in the view class like this:

initialize: function() {
   _.bindAll(this); //Make all methods in this class have `this` bound to this class
}

answered Sep 29, 2012 at 18:38

blockhead

9,7053 gold badges46 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Nyxynyx Over a year ago

I added _.bindAll(this, 'render', 'close'); but got the same error

blockhead Over a year ago

What is this.model equal to?

Nyxynyx Over a year ago

Great it works now! Using add:true and changing the render to trigger on add instead of reset which sounds strange to me

blockhead Over a year ago

Please don't use this answer as is...it is considered bad practice, and is being deprecated and removed from underscore.

Ben Over a year ago

@blockhead - good to know, will do. For those wondering what the solution is, then, read the comments on the OP.

Collectives™ on Stack Overflow

Backbone.js: Uncaught TypeError: Object #<Object> has no method 'get'

1 Answer 1

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related