Java statement can't execute my query

Question

I have a problem when I try to execute my query in Java. when I try to add an object to my database in SQL, it gives me a error saying that the instruction don't send the result set. When I execute the query in sql server, it work fine and it insert the object. Please help me.

public void addAlbum(String title, double price, String genre, String date, String home, String image) {

int number = getData().size();

boolean isThere = false;    

Statement statement;

for(int i = 0; i < getData().size();i++){

    if(getData().get(i).getTitle().equals(title)){

        isThere = true;

    }

}

if(!isThere){

    try{


        statement = connexion.createStatement();
        String query = "use albums INSERT INTO dbo.Album(Album.artist_number, title, price, genre, date, home, image) VALUES(" + number + ", '" + title + "', " + price + ", '" + genre + "', '" + date + "', '" + home + "', '" + image + "')";

        statement.executeQuery(query);

        getData().add(new Album(String.valueOf(number),title, price, genre, date, home));

        fireTableRowsInserted(getData().size() -1, getData().size() -1);

    }catch(SQLException e){

        JOptionPane.showMessageDialog(null,
                "Error "
                        + e.getMessage(), "Result",
                JOptionPane.ERROR_MESSAGE);

    }       


}else{

    JOptionPane.showMessageDialog(null,
            "There is already an album with this name", "Result",
            JOptionPane.ERROR_MESSAGE);

}
}

use albums INSERT INTO probably is probably not valid without a semicolon, and very well may not work with one. Normally you would not have a use DBNAME statement, that would be part of your connection string. Also you have SQL injection Bobby O'Tables. — aquinas
– aquinas, Commented Sep 30, 2012 at 19:27

Bhesh Gurung · Accepted Answer · 2012-09-30 19:25:02Z

2

You need to use Statement.executeUpdate(String) for INSERT. Statement.executeQuery(String) is for SELECT.

PreparedStatements are better, easier and safer. Using Prepared Statements.

answered Sep 30, 2012 at 19:25

Bhesh Gurung

51.1k23 gold badges96 silver badges147 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Augusto Over a year ago

And avoid mixing your UI code with DB code! Try using a design pattern such as Model-View-Controller

Collectives™ on Stack Overflow

Java statement can't execute my query

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related