Why iterating over ArrayIterator ending with endless loop?

Question

Array in my code is quite big so I pasting it in pastebin. http://pastebin.com/6tviT2Xj

I don't understand why I am getting endless loop

Logic of this script is:

$it = new ArrayIterator($options);
while($it->valid()) {
    print $it->key();
    print $it->current();
}

Not using foreach when using iterators seems so like PHP3... ;) — Sven
– Sven, Commented Oct 3, 2012 at 13:35
You should use foreach. Better performance than while. Less error prone, like you demonstrated. — Sven
– Sven, Commented Oct 3, 2012 at 13:43
@Sven - Do you have any benchmarks for the better performance you claim? — nickb
– nickb, Commented Oct 3, 2012 at 13:53

Björn · Accepted Answer · 2012-10-03 13:42:44Z

7

Because you never move in you iterator (with ArrayIterator::next()).

while ($it->valid()) {
    ...
    $it->next();
}

edited Oct 3, 2012 at 13:42

answered Oct 3, 2012 at 13:31

Björn

29.4k9 gold badges67 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Baba Over a year ago

Just Curios .. did you test this code ??? .. You would know it has errors if you did

Björn Over a year ago

@Baba - No, I just added the $it->next() -- because that's the cause of the problem. What errors do you mean?

Baba Over a year ago

Just edited your code with proper formatting .. you can see the diffence

kawashita86 · Accepted Answer · 2012-10-03 13:32:05Z

3

you should use $it->next(); else you will cicle over the same key eternally

answered Oct 3, 2012 at 13:32

kawashita86

1,5833 gold badges18 silver badges25 bronze badges

Comments

Teena Thomas · Accepted Answer · 2012-10-03 13:33:46Z

2

you're iterating over current element, you need to do $it->next(); to point/go to the next element

answered Oct 3, 2012 at 13:33

Teena Thomas

5,2091 gold badge15 silver badges17 bronze badges

Comments

Baba · Accepted Answer · 2012-10-03 13:50:13Z

1

The main issue is not using $it->next(); in your but that still many not give you the desired output because If you run print $it->current(); it would only return Array since you can not output array information with print.

You should be using RecursiveArrayIterator and RecursiveIteratorIterator since you are dealing with multidimensional array

To get all values try :

$it = new RecursiveIteratorIterator(new RecursiveArrayIterator($options));
foreach ( $it as $key => $val ) {
    echo $key . ":" . $val . "\n";
}

See full demo : http://codepad.viper-7.com/UqF18q

edited Oct 3, 2012 at 13:50

answered Oct 3, 2012 at 13:33

Baba

95.3k29 gold badges172 silver badges222 bronze badges

Collectives™ on Stack Overflow

Why iterating over ArrayIterator ending with endless loop?

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related