Print different array elements

Question

I want to display different string array elements like this:

Clubs 1
Hearts Ace
Diamonds 9

CardGame.java:

public class CardGame {
    public static void main(String[] args){
        String[] suit = { "Clubs", "Hearts", "Diamonds", "Spades" };
        String[] deck = { "2", "3", "4", "5", "6", "7", "8", "9", "10",
                        "Jack", "Queen", "King", "Aces" };

        int i = (int) ( Math.random() * deck.length );
        int j = (int) ( Math.random() * suit.length );


        for( int a = 0; a < 7; a++ ) {
            System.out.println( "Deck " + deck[i] + " Suit " + suit[j] );
        }

        System.out.println();
    }
}

How will I do it? Point me to correct logic of displaying those different elements. Thanks.

Well, look at where you're looping... and then look at where you're setting the values of i and j. How do you expect what you're printing to change if i and j don't change? (Also note that your arrays are misnamed. The suits are hearts, clubs, diamonds and spades... — Jon Skeet
– Jon Skeet, Commented Oct 9, 2012 at 8:29
You want to display all the possible combinations and in random order ? — Jayy
– Jayy, Commented Oct 9, 2012 at 8:30
@KaipaMSarma yup I want them random and the possible combinations. — user1410081
– user1410081, Commented Oct 9, 2012 at 8:37

gefei · Accepted Answer · 2012-10-09 08:30:38Z

3

put

int i = (int) ( Math.random() * deck.length );
int j = (int) ( Math.random() * suit.length );

into the for loop, so that in every iteration a new random card is generated

answered Oct 9, 2012 at 8:30

gefei

20k9 gold badges54 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Juvanis · Accepted Answer · 2012-10-09 08:34:55Z

2

    int times = 10; // Say you want it 10 times, in your code it's 7.

    for (int i = 0; i < times; i++) {
        System.out.println(deck[(int) (Math.random() * deck.length)]
                 + " : " + suit[(int) (Math.random() * suit.length)]);
    }

answered Oct 9, 2012 at 8:34

Juvanis

26k5 gold badges75 silver badges88 bronze badges

1 Comment

user1410081 Over a year ago

Good one liner ;) I salute you sir.

Daniel K · Accepted Answer · 2012-10-09 08:38:26Z

0

public class CardGame {
    public static void main(String[] args) {

         String[] deck = { "Clubs", "Hearts", "Diamonds", "Spades" };
         String[] suit = { "2", "3", "4", "5", "6", "7", "8", "9", "10",
                            "Jack", "Queen", "King", "Aces" };

         for( int a = 0; a < 7; a++ ) {
             int i = (int) ( Math.random() * deck.length );
             int j = (int) ( Math.random() * suit.length );

             System.out.println( "Deck " + deck[i] + " Suit " + suit[j] );
         }
         System.out.println();
    }
}

edited Oct 9, 2012 at 8:38

Daniel K

7,1012 gold badges29 silver badges35 bronze badges

answered Oct 9, 2012 at 8:32

PbxMan

7,6331 gold badge40 silver badges40 bronze badges

Comments

Baz · Accepted Answer · 2012-10-09 08:40:20Z

0

int i = (int) ( Math.random() * deck.length );
int j = (int) ( Math.random() * suit.length );

put into for loop because your new generate i j value get

edited Oct 9, 2012 at 8:40

Baz

37k11 gold badges75 silver badges101 bronze badges

answered Oct 9, 2012 at 8:37

mahipal purohit

2641 silver badge10 bronze badges

Comments

Daniel Cisek · Accepted Answer · 2012-10-09 08:50:20Z

0

I don't quite get your question - if you want many random cards, or all of them.

All of them:

for (String cardSuit: suit) {
    for (String cardDeck: deck) {
        System.out.println(cardDeck + " " + cardSuit);
    }
}

Random (given number):

Random rnd = new java.util.Random();
for (int i = 0; i < number; i++) {
    String cardSuit = suit[rnd.nextInt(suit.length)],
           cardDeck = deck[rnd.nextInt(deck.length)];
    System.out.println(cardDeck + " " + cardSuit);
}

edited Oct 9, 2012 at 8:50

answered Oct 9, 2012 at 8:34

Daniel Cisek

9513 gold badges9 silver badges23 bronze badges

1 Comment

Daniel Cisek Over a year ago

Yeah, I've forgot to access the array. Fixed it.

Jayy · Accepted Answer · 2012-10-09 08:57:05Z

import java.util.HashSet;
import java.util.Set;

public class CardGame { 

    public static void main(String[] args){ 

        String[] deck = { "Clubs", "Hearts", "Diamonds", "Spades" }; 
        String[] suit = { "2", "3", "4", "5", "6", "7", "8", "9", "10", 
                                    "Jack", "Queen", "King", "Aces" }; 

        Set<String> s = new HashSet<String>();
        int totalCards=0;

        while(s.size() < (deck.length * suit.length)){ 
            int i = (int) ( Math.random() * deck.length ); 
            int j = (int) ( Math.random() * suit.length ); 

            if(!s.contains("Deck " + deck[i] + " Suit " + suit[j])){
                s.add("Deck " + deck[i] + " Suit " + suit[j]);
                totalCards++;
            }

        }

        System.out.println("Cards at Random: ");
        for(String str: s)
        System.out.println(str); 

        System.out.println("Total Cards: "+ totalCards);
    } 
}

This will return all 52 cards( all combinations) randomly

Collectives™ on Stack Overflow

Print different array elements

6 Answers 6

Comments

1 Comment

Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

1 Comment

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related