Passing variables within variables?

Question

I have an ajax function which looks like this (basically, it's simplified):

function getPage(targetURL, targetID, dataMethod, dataStream) {
  $.ajax({
    type: dataMethod,
    data: { dataStream },
    url: '../' + targetURL,
    success:
        function(server_response)   { 
            $('#' + targetID).html(server_response).show();
        }
    });
  return false;
}

I then want to call the function like this:

onclick="getPage('myPage.php', 'content', 'GET', 'someAction: add');"

And that is very good... But right now function thinks add is a variable... But in some cases, I need to declare someAction with a value, from within the onClick, like this:

onclick="getPage('myPage.php', 'content', 'GET', 'someAction: "add"');"

However, that is ofcourse not working... Neither does ofcourse:

onclick="getPage('myPage.php', 'content', 'GET', 'someAction: \"add\"');"

So what will a wise man do?

Well, for starters, a wise man wouldn't use onclick inline event handlers! — BenM
– BenM, Commented Oct 15, 2012 at 14:02
One option is: data: dataStream, and onclick="getPage('myPage.php', 'content', 'GET', 'someAction=add');". — Rob W
– Rob W, Commented Oct 15, 2012 at 14:02
Sure I will use $('#someid').click(function() { // Do somthing }); I'm still a newb, trying to figure things out :) — EibergDK
– EibergDK, Commented Oct 15, 2012 at 14:36

MadMage · Accepted Answer · 2012-10-15 14:03:25Z

1

This is because you are mixing strings and objects. In order to do what I think you want to do, you should call the function like this:

onclick="getPage('myPage.php', 'content', 'GET', { someAction: 'add' });"

i.e., you are passing an object as the fourth parameter, and not a string, then, in your function, you should treat that object as it is, i.e.

$.ajax({
  type: dataMethod,
  data: dataStream,
  url: '../' + targetURL,
  // ...

answered Oct 15, 2012 at 14:03

MadMage

1861 silver badge7 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jamiec · Accepted Answer · 2012-10-15 14:03:37Z

1

You're passing dataStream as a string, you shouldn't - it should be an object literal:

function getPage(targetURL, targetID, dataMethod, dataStream) {
  $.ajax({
    type: dataMethod,
    data:  dataStream ,
    url: '../' + targetURL,
    success:
        function(server_response)   { 
            $('#' + targetID).html(server_response).show();
        }
    });
  return false;
}

and then:

onclick="getPage('myPage.php', 'content', 'GET', {someAction: add});"

or

onclick="getPage('myPage.php', 'content', 'GET', {someAction: \"add\"});"

answered Oct 15, 2012 at 14:03

Jamiec

136k15 gold badges143 silver badges202 bronze badges

Comments

limos · Accepted Answer · 2012-10-15 14:04:49Z

1

It's expecting an object, so give it one:

onclick="getPage('myPage.php', 'content', 'GET', {someAction: add});"

Then inside the function:

    data: dataStream,

without the braces

answered Oct 15, 2012 at 14:04

limos

1,58612 silver badges15 bronze badges

Collectives™ on Stack Overflow

Passing variables within variables?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related