Question about NSMutableArray

Question

I currently try to fill and NSMutableArray with something like this:

deck = [[NSMutableArray alloc] initWithCapacity:52]; 
for (int suit = 0; suit <= 3; suit++) {
  for (int value = 1; value <= 13; value++) {
    ANormalCard *card = [[ANormalCard alloc] initWithSuit:suit value:value];
    [deck addObject:card];
    [card autorelease];
  }
}

Now the problem is when I go over the array, only the last object I create is 52x in the array. Any idea what I am doing wrong ?

Edit:

the -initWithSuit looks like this:

- (id) initWithSuit:(int)suit value:(int)val {
    if ((self = [super init])) {
        theSuit = suit;
        theValue = val;
    }
    return self;
}

I'm using NSEnumerator * enumerator = [deck objectEnumerator]; and a while loop to iterate over the array.

make sure that initWithSuit:value: is not returning always the same object. — cocoafan
– cocoafan, Commented Aug 18, 2009 at 20:45
I don't think I understood the question - what is the problem with the last object? — Aviad Ben Dov
– Aviad Ben Dov, Commented Aug 18, 2009 at 20:46
That code looks fine. How does your actual code differ? And can you post the code for initWithSuit:value: ? — grahamparks
– grahamparks, Commented Aug 18, 2009 at 20:46
At this point, I don't think the question is answerable without seeing the complete source code. Can you create a minimal version that still exhibits the behaviour? — grahamparks
– grahamparks, Commented Aug 19, 2009 at 15:04

Quinn Taylor · Accepted Answer · 2009-08-19 16:09:48Z

2

This code snippet looks perfectly fine. The problem is likely in your -initWithSuit:value: method — I'd check whether you're accidentally initializing the cards incorrectly.

Edit: The init method just posted by the asker looks fine as well. What is the exact output you're seeing that leads you to believe that only the last object has been added 52 times? How exactly are you examining the array? (Your comment says you're using an NSEnumerator, but can you edit your question to include the snippet you're using for that?

edited Aug 19, 2009 at 16:09

answered Aug 18, 2009 at 21:12

Quinn Taylor

44.8k16 gold badges116 silver badges135 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

eemceebee Over a year ago

the -initWithSuit looks like this : -(id)initWithSuit:(int) suit value:(int)val { if ((self=[super init]) ) { theSuit = suit; theValue = val; } return self; }

Collectives™ on Stack Overflow

Question about NSMutableArray

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related