Add string to string in C with safe functions

Question

I want to copy the a file name to a string and append ".cpt" to it. But I am unable to do this with safe functions (strcat_s). Error: "String is not null terminated!". And I did set '\0', how to fix this using safe functions?

size = strlen(locatie);
size++;
nieuw = (char*)malloc(size+4);
strcpy_s(nieuw, size, locatie);
nieuw[size] = '\0';
strcat_s(nieuw, 4, ".cpt"); // <-- crash
puts(nieuw);

It appears your usage is incorrect. I have not used this function but as per documentation code should be strcat_s(nieuw, size, ".cpt"); as pointed in shf301's response — another.anon.coward
– another.anon.coward, Commented Oct 26, 2012 at 18:37

shf301 · Accepted Answer · 2012-10-26 18:29:39Z

11

The size parameter of the _s functions is the size of the destination buffer, not the source. The error is because there is no null terminator in nieuw in the first for characters. Try this:

size = strlen(locatie);
size++;
int nieuwSize = size + 4;
nieuw = (char*)malloc(nieuwSize );
strcpy_s(nieuw, nieuwSize, locatie);
nieuw[size] = '\0';
strcat_s(nieuw, nieuwSize, ".cpt"); // <-- crash
puts(nieuw);

answered Oct 26, 2012 at 18:29

shf301

31.5k2 gold badges57 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

another.anon.coward Over a year ago

+1, Though I have no experience with MS function just curious after reading documentation of strcpy_s, isn't nieuw[size] = '\0'; redundant?

shf301 Over a year ago

Yes it is redundant. strcpy_s will always null terminate the string.

Kylo · Accepted Answer · 2012-10-26 18:47:27Z

1

Maybe some standard solution?

const char * const SUFFIX = ".cpt";
size = strlen(locatie) + strlen(SUFFIX) + 1;  // +1 for NULL
nieuw = (char*)malloc(size);
snprintf(nieuw, size, "%s%s", locatie, SUFFIX);

answered Oct 26, 2012 at 18:47

Kylo

2,3301 gold badge21 silver badges24 bronze badges

1 Comment

kakyo Over a year ago

much nicer. I can't believe how much harder it is to get strcat_s working right.

lovaya · Accepted Answer · 2012-10-26 18:48:04Z

1

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main(void)
{
    char old[] = "hello";
    size_t size = strlen(old) + 5;;
    char *new_name = (char*)malloc(size);
    new_name[size-1] = '\0';
    strcpy_s(new_name, size, old);
    strcat_s(new_name, size, ".cpp");
    printf("%s\n", new_name);
    return 0;
}

answered Oct 26, 2012 at 18:48

lovaya

4633 silver badges3 bronze badges

Comments

user586399 · Accepted Answer · 2012-10-26 18:27:09Z

0

Why not

size = strlen(locatie);
size++;
nieuw = (char*)malloc(size+6);
strcpy_s(nieuw, size, locatie);
strcat_s(nieuw, 4, ".cpt");
puts(nieuw);
nieuw[size + 5] = '\0';

answered Oct 26, 2012 at 18:27

user586399

Comments

asbumste · Accepted Answer · 2012-10-26 18:27:53Z

0

Check out asprintf. It allows you to print to a string like printf

answered Oct 26, 2012 at 18:27

asbumste

4511 gold badge3 silver badges12 bronze badges

1 Comment

user1502256 Over a year ago

asprintf is not available for windows.

lovaya · Accepted Answer · 2012-10-26 18:47:02Z

0

size = strlen(locatie);
size++;
nieuw = (char*)malloc(size+4);
strcpy_s(nieuw, size, locatie);
nieuw[size] = '\0';
strcat_s(nieuw, size, ".cpt");
puts(nieuw)

;

edited Oct 26, 2012 at 18:47

answered Oct 26, 2012 at 18:33

lovaya

4633 silver badges3 bronze badges

Collectives™ on Stack Overflow

Add string to string in C with safe functions

6 Answers 6

2 Comments

1 Comment

Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

1 Comment

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related