Multiple AND OR statements in php MYSQL

Question

It seems there's something wrong with this. I don't get any distinct errors, but it's simply not doing what its supposed to be doing. I'm leaning towards there being a problem with the OR statements, but I've put the username in parenth, and the id slots in parenth, and neither work. Honestly, i'm only posting this here because five hours of looking at it got to be enough for me. Hopefully something looks blatantly wrong and it's not somewhere else in the code :/

$fetch_userone_idslots = mysql_query("SELECT id_1, id_2, id_3, id_4, id_5, id_6 FROM users WHERE id_1 = '$battle_id' || id_2 = '$battle_id || id_3 = '$battle_id || id_4 = '$battle_id || id_5 = '$battle_id || id_6 = '$battle_id && username == '$user_logged_in'");

while ($row = mysql_fetch_array($fetch_userone_idslots)){
$useroneidslot_1 = $row['id_1'];
$useroneidslot_2 = $row['id_2'];
$useroneidslot_3 = $row['id_3'];
$useroneidslot_4 = $row['id_4'];
$useroneidslot_5 = $row['id_5'];
$useroneidslot_6 = $row['id_6'];
}

Welcome to Stack Overflow! Please, don't use mysql_* functions in new code. They are no longer maintained and the deprecation process has begun on it. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial. — Madara's Ghost
– Madara's Ghost, Commented Oct 28, 2012 at 10:56
Reading the error message mysql provides is the first step to more knowledge and understanding. Its kinda sad you need a peer review of your code to find out about an error mysql already tells you. — hakre
– hakre, Commented Nov 4, 2012 at 17:14

juergen d · Accepted Answer · 2012-10-28 10:53:32Z

4

You are using a == which does not exist in MySQL. Use just =. You can simplify your query like this

SELECT id_1, id_2, id_3, id_4, id_5, id_6 FROM users
WHERE '$battle_id' in (id_1, id_2, id_3, id_4, id_5, id_6) 
and username = '$user_logged_in'

answered Oct 28, 2012 at 10:53

juergen d

205k40 gold badges305 silver badges377 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

juergen d Over a year ago

Use can use != in MySQL. But normally <> is used.

Jocelyn Over a year ago

Both <> and != may be used. See Operator 'not equal'

John Woo · Accepted Answer · 2012-10-28 10:52:54Z

1

in MySQL you need to use AND or OR not || and &&. and one more thing there is no ==, use only =.

SELECT id_1, id_2, id_3, id_4, id_5, id_6 
FROM users 
WHERE (
      id_1 = '$battle_id' OR 
      id_2 = '$battle_id' OR  
      id_3 = '$battle_id' OR 
      id_4 = '$battle_id' OR  
      id_5 = '$battle_id' OR  
      id_6 = '$battle_id'
      ) AND 
      username = '$user_logged_in'

answered Oct 28, 2012 at 10:52

John Woo

265k70 gold badges509 silver badges500 bronze badges

1 Comment

Jocelyn Over a year ago

Wrong for || and &&. See Logical operators in MySQL

Reflective · Accepted Answer · 2012-11-05 00:05:32Z

0

EDIT:

Don't use == if you need an eqation. In SQL == is just =. SQL is differnet that C, it's a query language and syntax is different because it's used for different puprose. My advice is to follow the SQL sintax to avoid similar mistakes.

edited Nov 5, 2012 at 0:05

answered Oct 28, 2012 at 10:53

Reflective

3,9371 gold badge17 silver badges25 bronze badges

4 Comments

Jocelyn Over a year ago

Wrong for || and &&. See Logical operators in MySQL

Reflective Over a year ago

yes but there is no == it is just = in equations. It is better to follow the correct SQL syntax even || and && may work in MySQL. As you see followng this wrong way the guy is used == instead of =.

Jocelyn Over a year ago

Your answer is wrong because it says || and && may not be used in MySQL. Update your answer to make it more clear by clicking 'edit'.

Reflective Over a year ago

@Jocelyn, my friend, my answer is half right and half wrong - do you think == could be used in SQL expression? If you prefer the wrong part - it is ok for me - but following the SQL standart is better than the concreate implementation in MySQL. I will edit my answer, but giving the guy a feeling that SQL is C like language will reflect on understanding of SQL and it is not a good idea. Any way that's not my problem :)

Collectives™ on Stack Overflow

Multiple AND OR statements in php MYSQL

3 Answers 3

2 Comments

1 Comment

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related