run jQuery function by inline onClick and use function variable/reference

Question

I am very new to this, but I wrote this and thought it would work first time, but I get an 'ReferenceError: Can't find variable: street' console error.

I get this error if I click on the 'Street' button.

It's quite basic but this is the first time I've made a function to use a var/ref from the onClick attribute.

Please see onClick markup...

<a href="#" title="View Supersport" onclick="bikeFilter(supersport)">Supersport</a>

<a href="#" title="View Street" onclick="bikeFilter(street)">Street</a>

<a href="#" title="View Cruiser" onclick="bikeFilter(cruiser)">Cruiser</a>

<a href="#" title="View Scooter" onclick="bikeFilter(scooter)">Scooter</a>      


<a href="#" title="Motocross" onclick="bikeFilter(motocross)">Motocross</a>

<a href="#" title="Enduro" onclick="bikeFilter(enduro)">Enduro</a>

<a href="#" title="Kids" onclick="bikeFilter(kids)">Kids</a>

then please see my function, which gets the ref error above...

Also please note I am trying to use the onClick var/ref within my function so I can target specific elements relative to the button being clicked.

bikeFilter = function (y) {

    $('.bike').fadeOut();

    scrollTo(186);

    $('.bike[data-group=' + y + ']').fadeIn();

    bikeSliderNav();

    bikeSlider();

    return false;

}

Any expert advice would be really helpful.

Thanks in advance.

rano · Accepted Answer · 2012-11-04 19:22:36Z

1

You'd probably wanna pass a String as input to your function and not the name of an undeclared and uninstantiated variable.

Try to use the single quotes to refer it as a String constant (you need single quotes since you are already using double quotes to tell your html tag the attribute value):

onclick="bikeFilter('scooter')"

Take a look here to see the difference in data typing in js, and here for a quick start about functions.

answered Nov 4, 2012 at 19:22

rano

5,6975 gold badges43 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Joshc Over a year ago

Thanks for those links, I will take a look and learn. Nice one!

rano Over a year ago

That tutorial is easy to follow but pretty much complete : )

Mustafa Genç · Accepted Answer · 2012-11-04 19:21:11Z

1

You should use them like :

onclick="bikeFilter('motocross')"

Don't forget to put ' around your parameters

answered Nov 4, 2012 at 19:21

Mustafa Genç

2,58920 silver badges36 bronze badges

Collectives™ on Stack Overflow

run jQuery function by inline onClick and use function variable/reference

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related