Syntax error, insert ";" to complete ReturnStatement

Question

I'm getting the error "Syntax error, insert ";" to complete ReturnStatement" in the following code on the line "return int i;"

public class RecordActivity extends Activity {

@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_record);

    int i = intent.getIntExtra(MainActivity.EXTRA_INDEX, 0);
    int j = i+1;
    final String[]names = getResources().getStringArray(R.array.names);

    final TextView nameView = (TextView) findViewById(R.id.vNames);
    String vName = names[i];
    nameView.setText(vName);

    Button nextButton = (Button) findViewById(R.id.nextButton);
    nextButton.setOnClickListener(new OnClickListener() {
        public static onClickView(View v) {
            i=i+1;
            return int i;
        }
        }
    );
    }
    //...
}

I am trying to iterate the index of an array on button click and so am getting the onClick method to return the index 'i' so I can put it into a looping statement. I've checked all brackets close and can't see where I would be missing the ';'. Any help on this would be appreciated.

also, your onClickView should be a void and not a (nothing), you should declare i outside the onCreate method to be able to access and modify it in the onClickListener, and you cannot return an int from this method (even if you could, you wouldn't receive it anywhere). Plus, incrementing i won't actually do anything from what is visible of your code. — njzk2
– njzk2, Commented Nov 5, 2012 at 14:05

Olaf Dietsche · Accepted Answer · 2012-11-05 13:58:24Z

1

Change this to:

public void onClickView(View v) {
    i=i+1;
}

because the return type is void, not int. See: View.OnClickListener

answered Nov 5, 2012 at 13:58

Olaf Dietsche

74.4k9 gold badges113 silver badges214 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nermeen · Accepted Answer · 2012-11-05 14:09:43Z

0

Declare int i in the activity, then in the onClick just increment it:

public class RecordActivity extends Activity {
  int i;

@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_record);

i = intent.getIntExtra(MainActivity.EXTRA_INDEX, 0);
int j = i+1;
final String[]names = getResources().getStringArray(R.array.names);

final TextView nameView = (TextView) findViewById(R.id.vNames);
String vName = names[i];
nameView.setText(vName);

Button nextButton = (Button) findViewById(R.id.nextButton);
nextButton.setOnClickListener(new OnClickListener() {
    public void onClickView(View v) {
        i=i+1;
    }
    }
);
}
//...

edited Nov 5, 2012 at 14:09

answered Nov 5, 2012 at 13:55

Nermeen

16k5 gold badges62 silver badges73 bronze badges

Comments

Fernando Cordeiro · Accepted Answer · 2012-11-05 13:56:05Z

0

I would try not redeclaring the variable, like:

return i;

answered Nov 5, 2012 at 13:56

Fernando Cordeiro

4032 silver badges11 bronze badges

Comments

user1415683 · Accepted Answer · 2012-11-05 13:58:05Z

0

Have you tried changing return int i; to return i; and changing the return type from void to int? It doesn't makes sense to 'redeclare' i while trying to return it.

Also, I believe that the return type should be void, so just remove the return statement.

answered Nov 5, 2012 at 13:58

user1415683

Collectives™ on Stack Overflow

Syntax error, insert ";" to complete ReturnStatement

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related