converting textbox string to int

Question

I'm trying to compare and multiply 2 random number variables with the int value entered in textboxes. If it is the correct increment the correct answers it does not increase the number although it increment works alone but it does not work with the textbox.

private void button1_Click(object sender, EventArgs e)
{
    int x = Randomnumber.Next(12);
    int z = Randomnumber.Next(12);

    //int cv = +correct;
    textBox2.Text = x.ToString();
    textBox3.Text = z.ToString();

    int s = x * z;
    if (s == int.Parse(textBox4.Text))
    {
        correct++;
        numbercorrect.Text = correct.ToString();
    }
}

i can't identify any apparent problems at the moment. what is it supposed to do? — Sam I am says Reinstate Monica
– Sam I am says Reinstate Monica, Commented Nov 6, 2012 at 1:12
I dont really understand what the problem is. You should tell us what is happening with your current code, what you're expecting, and how they differ. — caesay
– caesay, Commented Nov 6, 2012 at 1:13
i try to make mathmatical game to answer the multipiling of random numbers and compare the answer in the text box with the correct answer and if it is true increment the value of correct answer textbox by 1 for every correct answer — yat programmer
– yat programmer, Commented Nov 6, 2012 at 1:16
My guess is that int.Parse is breaking because the user hasn't typed an int. Use int.TryParse. — Dour High Arch
– Dour High Arch, Commented Nov 6, 2012 at 1:22

TyCobb · Accepted Answer · 2012-11-06 02:01:45Z

2

EDIT This is assuming that you are trying to have the user enter their guess before the button is pressed. Figured I would put this disclaimer here since there is confusion exactly what you are trying to do.

Looking at your current code sample, you are trying parse textBox4.Text, however, you are not setting textBox4.Text anywhere in your code sample. If textBox4.Text is string.Empty, int.Parse will throw an exception.

You should also look into doing Int.TryParse as it will tell you if it worked without throwing an exception.

EDIT: Since this is a guessing game, you should be validating the user's entry in textBox4 before continuing.

private void button1_Click(object sender, EventArgs e)
{
    int answer;
    if(!int.TryParse(textBox4.Text, out answer))
    {
        MessageBox.Show("Please Enter A Valid Integer.");
        return;
    }
    int x = Randomnumber.Next(12);
    int z = Randomnumber.Next(12);

    //int cv = +correct;
    textBox2.Text = x.ToString();
    textBox3.Text = z.ToString();

    int s = x * z;
    if (s == answer)
    {
        correct++;
        numbercorrect.Text = correct.ToString();
    }
}

edited Nov 6, 2012 at 2:01

answered Nov 6, 2012 at 1:30

TyCobb

9,1091 gold badge36 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

caesay Over a year ago

Nice catch on the notice that TB4 isnt getting set.

TyCobb Over a year ago

@anorton Correct. I assumed the same thing. I merely mentioned it because he didn't show an example of it with a valid answer and that he can't blindly trust the value is a valid int.

Tyler Lee · Accepted Answer · 2012-11-06 01:10:32Z

0

You're comparing the textbox value to the product of two random values. Unless you know what those two random numbers are before you push the button, the if will fail.

answered Nov 6, 2012 at 1:10

Tyler Lee

2,82517 silver badges24 bronze badges

Comments

apnorton · Accepted Answer · 2012-11-06 02:04:50Z

0

This subroutine will be run as soon as Button1 is pressed. This will display two random numbers for the user to multiply. (Displayed in TB2 and TB3.)

Now, as soon as these numbers are displayed (and before the user has a chance to enter any answer) the program checks the value in TB4. This is empty, and throws an error when the parse is attempted.

Try breaking this into 2 subroutines with 2 buttons: one button to display a new problem, and one button to check the answer.

EDIT: Code added. (Note: I wrote this freehand--don't know if it would compile or not... just get the general idea. Note the button names.)

//This routine sets up the problem for the user.
private void btnGenerateProblem_Click(object sender, EventArgs e) { 
  //Get 2 random factors
  int x = Randomnumber.Next(12);
  int z = Randomnumber.Next(12);

  //Display the two factors for the user
  textBox2.Text = x.ToString(); 
  textBox3.Text = z.ToString(); 
}

//This routine checks the user's answer, and updates the "correct count"
private void btnCheckAnswer_Click(object sender, EventArgs e) { 
  //Get the random numbers out of the text boxes to check the answer
  int x = int.Parse(textBox2.Text);
  int z = int.Parse(textBox3.Text);

  //Compute the true product
  int s = x * z; 

  //Does the true product match the user entered product?
  if (s == int.Parse(textBox4.Text))  {
    correct++; 
    numbercorrect.Text = correct.ToString(); 
  }
}

Add verification code at the beginning of btnCheckAnswer_Click.

edited Nov 6, 2012 at 2:04

answered Nov 6, 2012 at 1:41

apnorton

2,4501 gold badge21 silver badges34 bronze badges

5 Comments

TyCobb Over a year ago

I believe the answer is supposed to come first before the button is pressed. It is a guessing game. He just needs to validate that the user's entry is valid before running.

apnorton Over a year ago

It is supposed to be a guessing game, yes. But how is the user supposed to guess between the display of the random numbers and the checking code at the end of the snippet? The random numbers aren't displayed until this code snippet is run. The user must enter the correct answer between lines 10 and 11 in the snippet above. ;)

TyCobb Over a year ago

Hmmm. I had assumed that the user guesses the value before the numbers are generated (entered their guess in textBox4) and then hit the button to see if they guessed correctly which would then display the values in the text boxes and increment the counter if correct. Perhaps I am just not understanding exactly what he is trying for.

yat programmer Over a year ago

thank you every one your comments was useful for me and helped me to get the correct code i will post it now

apnorton Over a year ago

If a post was helpful, you can give it an up vote--this rewards those who replied. You can also "accept" an answer, which provides more reputation to that one answer. :)

yat programmer · Accepted Answer · 2012-11-06 23:29:09Z

0

    private void button1_Click(object sender, EventArgs e)
    {


        int result = Convert.ToInt32(textBox4.Text); int x, z;

        if (Convert.ToInt32(textBox2.Text) * Convert.ToInt32(textBox3.Text) == result)
        {
            correct++;
            numbercorrect.Text = correct.ToString();
            Randomnumber.Next(12);
            textBox2.Text = Randomnumber.Next(12).ToString();
            textBox3.Text = Randomnumber.Next(12).ToString();

        }

}

answered Nov 6, 2012 at 23:29

yat programmer

974 silver badges11 bronze badges

Collectives™ on Stack Overflow

converting textbox string to int

4 Answers 4

2 Comments

Comments

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related