Issues with Javascript For and Arrays

Question

I'm trying to dynamically hide specific photos on a page, through Javascript, by selecting their data-id attribute and hiding the photo. This is being achieved through Ajax grabbing the IDs from a TXT file, splitting them in to an Array, and then using jQuery to hide the img with that ID. Note that this function is being passed through a setInterval every 3 seconds...

    function getBlockedIDs() {
            var stringData = $.ajax({
                    url: "http://s61892.gridserver.com/zone/twitter2/blocked.txt",
                    async: false
            }).responseText;
            var blockedArray = new Array();
            blockedArray = stringData.split(",");
            var length = stringData.length
            for (var i = 0; i < length; i++) {
                    $('img.tweetphoto[data-id="' + stringData[i] + '"]').hide();
            }
    }

My problem is, it's not working! No errors are thrown from the console. What's wrong with my code? The idea behind this is to block specific (inappropriate) photos without reloading the page.

Any help is appreciated!

Have you used Firebug (or another debugger) to see what's going on? That should be step 1. — jahroy
– jahroy, Commented Nov 14, 2012 at 6:55
you can try to use the attribute selector without quotes, e.g: tim.tweetphoto[data-id=foo] — Nippey
– Nippey, Commented Nov 14, 2012 at 7:09

HBP · Accepted Answer · 2012-11-14 06:56:21Z

1

Are you sure you want to use stringData inside the for loop and not blockedArray? If so change the assignment to length also.

My version would look something like :

     function getBlockedIDs() {
        var blockedArray = $.ajax({
                url: "http://s61892.gridserver.com/zone/twitter2/blocked.txt",
                async: false
        }).responseText.split (/\s*,\s*/);
        for (var i = blockedArray.length; i--;) {
                $('img.tweetphoto[data-id="' + blockedArray[i] + '"]').hide();
        }
}

answered Nov 14, 2012 at 6:56

HBP

16.1k6 gold badges30 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Naor · Accepted Answer · 2012-11-14 07:09:18Z

0

I would do something like:

function getBlockedIDs() {
    $.get("http://s61892.gridserver.com/zone/twitter2/blocked.txt", function(stringData) {
        var blockedArray = stringData.split(/\s*,\s*/);
        for (var i = 0; i < blockedArray.length; i++) {
            $('img.tweetphoto[data-id="' + blockedArray[i] + '"]').hide();
        }
    });
}

answered Nov 14, 2012 at 7:09

Naor

24.3k50 gold badges158 silver badges273 bronze badges

Collectives™ on Stack Overflow

Issues with Javascript For and Arrays

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related